Minor fixes for Graph Analytics #1042
Conversation
- Update count percentage in properties. - Separate incoming and outgoing relations. - Add count in relations.
|
|
| <div> | ||
| <h2>Out going</h2> | ||
| {renderSource} | ||
| <h2>Incoming</h2> |
There was a problem hiding this comment.
Could we increase the top margin for the Incoming here a bit?
| <h2>Out going</h2> | ||
| {renderSource} | ||
| <h2>Incoming</h2> | ||
| {renderDestination} |
There was a problem hiding this comment.
I would recommend flipping the order, or at least the arrows to preserve the link direction (form the graph).
There was a problem hiding this comment.
Are you suggesting that we do <--- for incoming and --> for outgoing?
There was a problem hiding this comment.
either that, or swap the order (Dataset --> isPartOf)
There was a problem hiding this comment.
ideally I would prefer swapping the order as it's visually more accurate
There was a problem hiding this comment.
Based on the order in which the properties appear, I think changing the arrow direction is better and I have updated code to reflect that.
|
Would it also be possible to use unicode arrows instead, like for example this one: https://unicode-table.com/en/1F812/ or https://unicode-table.com/en/279E/? |
Co-authored-by: Bogdan Roman <bogdan.roman@epfl.ch>
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M4 #1042 +/- ##
===========================================
Coverage ? 66.61%
===========================================
Files ? 22
Lines ? 668
Branches ? 144
===========================================
Hits ? 445
Misses ? 223
Partials ? 0 Continue to review full report at Codecov.
|
|
|
Done. Thanks for the suggestion. |
* Minor fixes for Graph Analytics - Update count percentage in properties. - Separate incoming and outgoing relations. - Add count in relations. Co-authored-by: Bogdan Roman <bogdan.roman@epfl.ch>
Fixes BlueBrain/nexus/issues/3090, Fixes BlueBrain/nexus/issues/3088, Fixes BlueBrain/nexus/issues/3089
Description
How has this been tested?
Types of changes
Checklist: