Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for Graph Analytics #1042

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Conversation

dhaneshnm
Copy link
Contributor

  • Update count percentage in properties.
  • Separate incoming and outgoing relations.
  • Add count in relations.

Fixes BlueBrain/nexus/issues/3090, Fixes BlueBrain/nexus/issues/3088, Fixes BlueBrain/nexus/issues/3089

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

- Update count percentage in properties.
- Separate incoming and outgoing relations.
- Add count in relations.
@dhaneshnm
Copy link
Contributor Author

Screenshot 2022-02-08 at 09 13 18

<div>
<h2>Out going</h2>
{renderSource}
<h2>Incoming</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we increase the top margin for the Incoming here a bit?

<h2>Out going</h2>
{renderSource}
<h2>Incoming</h2>
{renderDestination}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend flipping the order, or at least the arrows to preserve the link direction (form the graph).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting that we do <--- for incoming and --> for outgoing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either that, or swap the order (Dataset --> isPartOf)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally I would prefer swapping the order as it's visually more accurate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the order in which the properties appear, I think changing the arrow direction is better and I have updated code to reflect that.

@bogdanromanx
Copy link
Contributor

Would it also be possible to use unicode arrows instead, like for example this one: https://unicode-table.com/en/1F812/ or https://unicode-table.com/en/279E/?

Co-authored-by: Bogdan Roman <bogdan.roman@epfl.ch>
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M4@b6f935d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M4    #1042   +/-   ##
===========================================
  Coverage            ?   66.61%           
===========================================
  Files               ?       22           
  Lines               ?      668           
  Branches            ?      144           
===========================================
  Hits                ?      445           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f935d...5fdc434. Read the comment docs.

@dhaneshnm
Copy link
Contributor Author

Screenshot 2022-02-08 at 13 43 48

@dhaneshnm
Copy link
Contributor Author

Would it also be possible to use unicode arrows instead, like for example this one: https://unicode-table.com/en/1F812/ or https://unicode-table.com/en/279E/?

Done. Thanks for the suggestion.

@dhaneshnm dhaneshnm merged commit a46884a into 1.7.0-M4 Feb 8, 2022
@dhaneshnm dhaneshnm deleted the 3090-graph-analytics-fixes branch February 8, 2022 14:28
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Minor fixes for Graph Analytics

- Update count percentage in properties.
- Separate incoming and outgoing relations.
- Add count in relations.

Co-authored-by: Bogdan Roman <bogdan.roman@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants