Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Correct the behaviour of 'missing' filter#1068

Merged
dhaneshnm merged 1 commit into
1.7.1from
3152-Missing-Values
Mar 18, 2022
Merged

Correct the behaviour of 'missing' filter#1068
dhaneshnm merged 1 commit into
1.7.1from
3152-Missing-Values

Conversation

@dhaneshnm
Copy link
Copy Markdown
Contributor

Fixes BlueBrain/nexus/issues/3152

Description

When other filters like 'type' is applied, missing filter should be an 'and', instead of an 'or' to make it aligned with user's expectation. Also fixes the issue with the check box value retention for missing values check box.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

- Change the filter from 'or' to 'and'.
- Retain the check box value on the filter menu.
@dhaneshnm dhaneshnm requested review from nicwells and smitfire March 17, 2022 05:31
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (1.7.1@e9ecb18). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             1.7.1    #1068   +/-   ##
========================================
  Coverage         ?   66.61%           
========================================
  Files            ?       22           
  Lines            ?      668           
  Branches         ?      144           
========================================
  Hits             ?      445           
  Misses           ?      223           
  Partials         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ecb18...e9d21c9. Read the comment docs.

@dhaneshnm dhaneshnm changed the title Correct the bhaviour of 'missing' filter Correct the behaviour of 'missing' filter Mar 17, 2022
@dhaneshnm dhaneshnm merged commit 364b019 into 1.7.1 Mar 18, 2022
@dhaneshnm dhaneshnm deleted the 3152-Missing-Values branch March 18, 2022 10:18
dhaneshnm pushed a commit that referenced this pull request May 20, 2022
- Change the filter from 'or' to 'and'.
- Retain the check box value on the filter menu.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants