Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4342 // Cypress tests for public studios #1410

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Oct 16, 2023

The following public studios are being tested:

  1. Thalamus
  2. Topological Sampling

Fixes #4342

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [X ] I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@Dinika Dinika force-pushed the 4342/cypress-tests-for-public-studios branch from 6d89bb6 to 0095ab4 Compare October 16, 2023 15:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9083b51) 49.59% compared to head (9232b30) 49.59%.
Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1410   +/-   ##
========================================
  Coverage    49.59%   49.59%           
========================================
  Files          249      249           
  Lines        11339    11339           
  Branches      2652     2652           
========================================
  Hits          5624     5624           
  Misses        5680     5680           
  Partials        35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dinika Dinika force-pushed the 4342/cypress-tests-for-public-studios branch 4 times, most recently from 26c65e4 to db6b921 Compare October 19, 2023 09:22
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
@Dinika Dinika force-pushed the 4342/cypress-tests-for-public-studios branch from db6b921 to 9232b30 Compare October 19, 2023 09:53
Copy link
Contributor

@bilalesi bilalesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dinika Dinika merged commit 37918c0 into develop Oct 19, 2023
1 check passed
@Dinika Dinika deleted the 4342/cypress-tests-for-public-studios branch October 19, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants