Add tagging func to a resource for a specific revision #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinika
approved these changes
Oct 31, 2023
| }, | ||
| { | ||
| pattern: /^[a-zA-Z0-9_-]+$/, | ||
| message: 'Tag must contains only letters and numbers', |
There was a problem hiding this comment.
Two things:
-
Just double checking, are dashes really allowed by delta? I thought it was only alpha-numeric characters or underscore. I may be misrembering though.
-
The message says that only letters and numbers are allowed. Maybe we should also add that dashes and underscores are also allowed.
There was a problem hiding this comment.
- Simon has mentioned that the orgs name and tags should have the same regex (may be we forget to mention the _ and -)
- you're right message updated.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1425 +/- ##
===========================================
- Coverage 49.65% 47.99% -1.66%
===========================================
Files 249 249
Lines 11339 11362 +23
Branches 2652 2655 +3
===========================================
- Hits 5630 5453 -177
- Misses 5673 5876 +203
+ Partials 36 33 -3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to tag a resource for a specific revision
Description
How has this been tested?
Types of changes
Checklist: