Stop registering FactorDefs to the UnitTable #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 70.04% 70.04%
=======================================
Files 190 190
Lines 25789 25786 -3
=======================================
- Hits 18064 18063 -1
+ Misses 7725 7723 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alkino
approved these changes
Apr 18, 2023
alkino
approved these changes
Apr 18, 2023
|
Logfiles from GitLab pipeline #116651 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
pushed a commit
that referenced
this pull request
Apr 20, 2023
* Stop parsing of FactorDefs by the UnitParser that registered them in the UnitTable to follow the same policy as NEURON * Throw error when trying to register unit that already exists in the UnitTable * Added tests for UNITS redefinition and correct registration of UnitDefs and FactorDefs * Use :g for printing factors of units in unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR we were registering Factor Definitions from the
UNITSblock of the mod file to theUnitTablewhich holds all the registered units with their values and dimensions.For example before this PR when we defined in the mod file:
We inserted to the
UnitTablethe new value for R and all the consequent unit declarations based onRwhere done using the new value.With this PR this is not allowed any more.
Factor Definitions which are in the form:
are only used to be printed to the generated C++ file.
Also redefinitions of Units which are in the form:
are also not allowed anymore and an exception is thrown in case they exist.
All of the above were done so that we follow the same logic as the NEURON code generator.
Fixes: #703