Drop fast_math and move CI from %intel to %oneapi #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
olupton
changed the title
alkino
approved these changes
May 4, 2023
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 70.07% 69.94% -0.13%
==========================================
Files 190 188 -2
Lines 25804 25636 -168
==========================================
- Hits 18081 17931 -150
+ Misses 7723 7705 -18
|
|
Logfiles from GitLab pipeline #120983 (:white_check_mark:) have been uploaded here! Status and direct links: |
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
May 4, 2023
* Look for nmodl.hpp not nmodl/fast_math.hpp. * nmodl/fast_math.hpp is removed in BlueBrain/nmodl#1042.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled by BlueBrain/spack#1992, BlueBrain/spack#1994 and neuronsimulator/nrn#2350;
%intelis going away soon.fast_mathtests forvexpm1did not pass with%oneapi. As this code seems to be unused, removing it is the pragmatic option.