Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to local variable. #1060

Merged
merged 2 commits into from
Sep 6, 2023

Fix new dangling references.

cc0d6ef
Select commit
Loading
Failed to load commit list.
Merged

Fix reference to local variable. #1060

Fix new dangling references.
cc0d6ef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 6, 2023 in 0s

69.96% (-0.03%) compared to 5339400

View this Pull Request on Codecov

69.96% (-0.03%) compared to 5339400

Details

Codecov Report

Patch coverage: 41.66% and project coverage change: -0.03% ⚠️

Comparison is base (5339400) 69.98% compared to head (cc0d6ef) 69.96%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage   69.98%   69.96%   -0.03%     
==========================================
  Files         188      188              
  Lines       25659    25661       +2     
==========================================
- Hits        17957    17953       -4     
- Misses       7702     7708       +6     
Files Changed Coverage Δ
src/language/templates/ast/ast.cpp 48.67% <0.00%> (-0.09%) ⬇️
src/language/templates/ast/ast.hpp 50.00% <ø> (ø)
src/language/templates/pybind/pyast.hpp 0.00% <0.00%> (ø)
src/visitors/sympy_replace_solutions_visitor.hpp 100.00% <ø> (ø)
src/visitors/sympy_replace_solutions_visitor.cpp 90.30% <33.33%> (+0.04%) ⬆️
src/codegen/codegen_cpp_visitor.cpp 85.82% <100.00%> (ø)
src/visitors/global_var_visitor.cpp 95.83% <100.00%> (ø)
src/visitors/neuron_solve_visitor.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.