-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve generated C++ header files in the nmodl::ast
namespace
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prefer passing by reference rather than copy when possible for `std::shared_ptr` and `std::vector` * Use nested namespace definitions * Improve indentation of generated headers for lisibility
ohm314
reviewed
Sep 26, 2023
alkino
reviewed
Sep 26, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
===========================================
+ Coverage 70.18% 88.61% +18.42%
===========================================
Files 188 169 -19
Lines 25627 12474 -13153
===========================================
- Hits 17987 11054 -6933
+ Misses 7640 1420 -6220
☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Logfiles from GitLab pipeline #156739 (:white_check_mark:) have been uploaded here! Status and direct links: |
nmodl::ast
namespace
iomaganaris
reviewed
Sep 28, 2023
iomaganaris
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution provides the following change:
nmodl::ast
namespace:std::shared_ptr
andstd::vector
You can find attached a diff of the
<build>/src/ast
directoryast.patch