Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Codegen ctors. #1171

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Simplify Codegen ctors. #1171

merged 1 commit into from
Feb 23, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Feb 23, 2024

No description provided.

@1uc 1uc marked this pull request as ready for review February 23, 2024 15:19
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (9df433b) to head (b07d1ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.02%     
==========================================
  Files         176      175       -1     
  Lines       12946    12934      -12     
==========================================
- Hits        11442    11434       -8     
+ Misses       1504     1500       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #195889 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit bc913ef into master Feb 23, 2024
21 checks passed
@1uc 1uc deleted the 1uc/simplify-ctors branch February 23, 2024 15:58
ohm314 pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants