Remove brittle unit-test. #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed test only checks if certain substrings are present. The golden testing automatically adds these tests for any usecase. Therefore, this test is not needed anymore. The usecase for implementing non-specific current, will add a version of a passive current; and test the values against the analytical reference. Ions are already covered by the `ionic` usecase. Array variables are covered by the `cnexp_array` usecase. Parameters coved by the `parameters` usecase. Simple ODEs are covered by `cnexp_*` usecases.
|
While developing NRN support in NMODL, these tests are very annoying. I can never find the difference; and it's completely redundant with #1131. The CNRN variety can be revisited ater, since code generated for CNRN shouldn't be changing right now, it doesn't cause any issues. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 88.38% 87.16% -1.23%
==========================================
Files 176 176
Lines 12946 12890 -56
==========================================
- Hits 11442 11235 -207
- Misses 1504 1655 +151 ☔ View full report in Codecov by Sentry. |
|
Logfiles from GitLab pipeline #195923 (:white_check_mark:) have been uploaded here! Status and direct links: |
ohm314
pushed a commit
that referenced
this pull request
May 21, 2024
The removed test only checks if certain substrings are present. The golden testing automatically adds these tests for any usecase. Therefore, this test is not needed anymore. The usecase for implementing non-specific current, will add a version of a passive current; and test the values against the analytical reference. Ions are already covered by the `ionic` usecase. Array variables are covered by the `cnexp_array` usecase. Parameters coved by the `parameters` usecase. Simple ODEs are covered by `cnexp_*` usecases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed test only checks if certain substrings are present. The golden testing automatically adds these tests for any usecase. Therefore, this test is not needed anymore.
The usecase for implementing non-specific current, will add a version of a passive current; and test the values against the analytical reference.
Ions are already covered by the
ionicusecase.Array variables are covered by the
cnexp_arrayusecase.Parameters coved by the
parametersusecase.Simple ODEs are covered by
cnexp_*usecases.