Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor testing of wheels #1174

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Refactor testing of wheels #1174

merged 5 commits into from
Feb 26, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Feb 26, 2024

  • add pytest-based tests to script
  • refactor to also work outside of top-level dir
  • use temp dirs everywhere to not pollute current dir

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (bc913ef) to head (d96d8e9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1174   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         175      175           
  Lines       12934    12934           
=======================================
  Hits        11434    11434           
  Misses       1500     1500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCGoran JCGoran marked this pull request as ready for review February 26, 2024 09:54
@JCGoran JCGoran requested a review from pramodk February 26, 2024 09:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (bc913ef) to head (0104e15).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1174   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         175      175           
  Lines       12934    12934           
=======================================
  Hits        11434    11434           
  Misses       1500     1500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #196118 (:white_check_mark:) have been uploaded here!

Status and direct links:

@JCGoran JCGoran requested a review from 1uc February 26, 2024 15:19
@JCGoran JCGoran merged commit 39922a3 into master Feb 26, 2024
19 checks passed
@JCGoran JCGoran deleted the jelic/refactor_test_wheel branch February 26, 2024 17:40
ohm314 pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants