Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usecases 'func_proc{,_pnt}'. #1182

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Improve usecases 'func_proc{,_pnt}'. #1182

merged 2 commits into from
Feb 28, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Feb 27, 2024

Check that if there's multiple instances of the mechanisms the functions and procedures use the values for the correct instance.

Check that if there's multiple instances of the mechanisms the functions
and procedures use the values for the correct instance.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (2cff7e0) to head (2919fd5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         175      175           
  Lines       12884    12884           
=======================================
  Hits        11232    11232           
  Misses       1652     1652           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #196482 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc marked this pull request as ready for review February 27, 2024 17:47
@1uc
Copy link
Collaborator Author

1uc commented Feb 28, 2024

Golden references changed: BlueBrain/nmodl-references#3

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, LGTM!

@1uc 1uc merged commit 25eb4a0 into master Feb 28, 2024
19 checks passed
@1uc 1uc deleted the 1uc/improve-usecase-func branch February 28, 2024 10:53
ohm314 pushed a commit that referenced this pull request May 21, 2024
Check that if there's multiple instances of the mechanisms the functions
and procedures use the values for the correct instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants