Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing directories #1203

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix parsing directories #1203

merged 2 commits into from
Mar 7, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Mar 6, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.60%. Comparing base (347f786) to head (c71ecbf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
+ Coverage   86.58%   86.60%   +0.01%     
==========================================
  Files         175      175              
  Lines       13006    13009       +3     
==========================================
+ Hits        11261    11266       +5     
+ Misses       1745     1743       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #198874 (:white_check_mark:) have been uploaded here!

Status and direct links:

@JCGoran JCGoran marked this pull request as ready for review March 7, 2024 10:21
@JCGoran JCGoran merged commit f8c8d23 into master Mar 7, 2024
20 checks passed
@JCGoran JCGoran deleted the jelic/fix_parsing_dirs branch March 7, 2024 16:32
ohm314 pushed a commit that referenced this pull request May 21, 2024
* Throw error if passing directory instead of file to `parse_file`
* Add test for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to driver.parse_file('.') exits program
4 participants