Bug fix for NEURON wheel creation #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when neuron is built with nmodl then nmodl related files should be installed in <prefix>/ and not in <prefix>/nmodl/.data - <prefix>/nmodl/.data is used when we build standalone wheels - add one mod file using sparse solver - nmodl will automatically use sympy solver
pramodk
force-pushed
the
pramodk/nmodl-neuron-wheel-fix
branch
from
f87365b
to
7a0cae7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
==========================================
+ Coverage 86.50% 86.67% +0.16%
==========================================
Files 176 176
Lines 13176 13176
==========================================
+ Hits 11398 11420 +22
+ Misses 1778 1756 -22 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
alkino
approved these changes
Apr 23, 2024
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #207353 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
The CI is green on NEURON side: https://dev.azure.com/neuronsimulator/nrn/_build/results?buildId=11802&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<prefix>/and not in<prefix>/nmodl/.data<prefix>/nmodl/.datais used when we build standalone wheelssympysolverThis was the root cause for neuronsimulator/nrn/issues/2494!