Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common codegen code to parent class CodegenCppVisitor #1251

Merged
merged 6 commits into from
May 13, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented May 7, 2024

Some of the codegen routines are identical for NEURON and coreNEURON, so we may as well put them in the parent class, notably:

  • print_function_or_procedure (EDIT: removed for now due to the need for workarounds for v in NEURON codegen)
  • print_table_replacement_function (code in Add TABLE statement #1247 does not actually need modifying)
  • print_table_check_function
  • get_table_statement
  • check_if_var_is_array
  • print_function_declaration

@bbpbuildbot

This comment has been minimized.

@JCGoran JCGoran changed the title Move common codegen code to parent class Move common codegen code to parent class CodegenCppVisitor May 7, 2024
@JCGoran JCGoran marked this pull request as ready for review May 7, 2024 11:08
@bbpbuildbot

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 98.77301% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.35%. Comparing base (299c249) to head (69a2a1c).

Files Patch % Lines
src/codegen/codegen_cpp_visitor.cpp 98.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   86.36%   86.35%   -0.01%     
==========================================
  Files         176      175       -1     
  Lines       13227    13214      -13     
==========================================
- Hits        11423    11411      -12     
+ Misses       1804     1803       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #210557 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit 41d558a into master May 13, 2024
20 checks passed
@1uc 1uc deleted the jelic/refactor_cpp_visitor branch May 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants