Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests. #1313

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix integration tests. #1313

merged 1 commit into from
Jun 12, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jun 12, 2024

There must not be a clash of FUNCTION and RANGE names.

There must not be a clash of FUNCTION and RANGE names.
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (c5ecfea) to head (e0d08f0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1313   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files         178      178           
  Lines       13415    13415           
=======================================
  Hits        11476    11476           
  Misses       1939     1939           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #216396 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc marked this pull request as ready for review June 12, 2024 09:14
@1uc 1uc requested a review from JCGoran June 12, 2024 09:52
Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, nrnivmodl fails with:

Error: alfa used as both variable and function in file glia_sparse.mod

while nmodl --neuron generates the file without issues, which it shouldn't.

@1uc
Copy link
Collaborator Author

1uc commented Jun 12, 2024

There's (now) a ticket for the issue: #1316

@1uc 1uc merged commit d226bef into master Jun 12, 2024
23 checks passed
@1uc 1uc deleted the 1uc/fix-integration-tests branch June 12, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants