Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in TABLE for POINT_PROCESS. #1342

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix bug in TABLE for POINT_PROCESS. #1342

merged 2 commits into from
Jul 15, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jul 12, 2024

Change the name to update_table_*. To avoid inconsistencies in the
name (and it's suffix) we introduce a function
table_update_function_name.

Fixes a bug related to incorrect use of rsuffix, which caused the
function name to be inconsistent for POINT_PROCESSES.

1uc added 2 commits July 12, 2024 14:19
Change the name to `update_table_*`. To avoid inconsistencies in the
name (and it's suffix) we introduce a function
`table_update_function_name`.

Fixes a bug related to incorrect use of `rsuffix`, which caused the
function name to be inconsistent for POINT_PROCESSES.
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.16%. Comparing base (332c8b3) to head (54d01a2).
Report is 2 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   86.14%   86.16%   +0.01%     
==========================================
  Files         179      179              
  Lines       13663    13659       -4     
==========================================
- Hits        11770    11769       -1     
+ Misses       1893     1890       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #221565 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc marked this pull request as ready for review July 12, 2024 15:22
@1uc 1uc merged commit 2387ba7 into master Jul 15, 2024
23 checks passed
@1uc 1uc deleted the 1uc/fix-table-bug branch July 15, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants