Skip to content

Commit

Permalink
Schemas and schema-based validation (#155)
Browse files Browse the repository at this point in the history
* added schemas for some edge and node types as well as circuit config
* Rework the circuit validation
* Removed non-BBP related checks
* Removed checking for missing fields (handled by schemas.py)
* Continue the checks as far as possible even if errors show up
* added skip-slow option (with default true) to the validate command
* Removed redundant test cases, combined some of them
* Added tests for schemas
* use unittest.mock instead of mock
* updated CHANGELOG

Co-authored-by: Joni Herttuainen <joni.herttuainen@epfl.ch>
  • Loading branch information
mgeplf and joni-herttuainen committed Aug 23, 2022
1 parent 2640307 commit bb5f643
Show file tree
Hide file tree
Showing 33 changed files with 1,558 additions and 1,046 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,23 @@ Changelog
Version v1.0.0
---------------

New Features
~~~~~~~~~~~~
- jsonschema based validation of h5 files and circuit configuration
- checks for required attributes and data types of attributes (in h5 files)

Improvements
~~~~~~~~~~~~
- Add black & isort to handle formatting
- Use libsonata to provide more of the functionality
- parsing config files
- accessing data
- Circuit validation changed to be more config-driven
- it now only validates objects defined in the circuit configuration file

Removed
~~~~~~~
- non-BBP Sonata circuit validation
- NodeStorage & EdgeStorage classes
- point_neuron support

Expand Down

0 comments on commit bb5f643

Please sign in to comment.