Fix circuit validation. Validation of morphologies was skipped when n…

…o rotations fields were present. (#143)
BlueBrain · Aug 5, 2021 · c58f214 · c58f214
1 parent 5e954dc
commit c58f214
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -12,6 +12,8 @@ Bug Fixes
 ~~~~~~~~~
 - Fix the morphology/model access using a numpy int (using a numpy integer to access
   the morphology/model used to fail).
+- Fix circuit validation. Validation of morphologies was skipped when no rotations fields were
+  present.
 
 Others
 ~~~~~

diff --git a/bluepysnap/circuit_validation.py b/bluepysnap/circuit_validation.py
@@ -308,7 +308,6 @@ def _check_rotations():
     if missing_fields:
         errors.append(fatal('Group {} of {} misses biophysical fields: {}'.
                             format(group_name, group.file.filename, missing_fields)))
-    _check_rotations()
     if 'components' not in config:
         errors.append(fatal('No "components" in config'))
         return errors
@@ -317,6 +316,7 @@ def _check_rotations():
     errors += _check_components_dir('biophysical_neuron_models_dir', components)
     if errors:
         return errors
+    _check_rotations()
     errors += _check_files(
         'morphology: {}[{}]'.format(group_name, group.file.filename),
         (Path(components['morphologies_dir'], m + '.swc') for m in group_df['morphology']),