Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsent Attachments Aren't Updated #637

Closed
joshuafhiggins opened this issue Apr 7, 2024 · 5 comments
Closed

Unsent Attachments Aren't Updated #637

joshuafhiggins opened this issue Apr 7, 2024 · 5 comments

Comments

@joshuafhiggins
Copy link

joshuafhiggins commented Apr 7, 2024

When unsending an attachment, either as the recipient or sending, the BlueBubbles Server doesn't broadcast the updated message event that the attachment was deleted. This means that, if the BueBubbles client didn't delete the attachment, unsent attachments aren't removed. If the client didn't download the attachment before it was unsent, then the BB client fails to fetch the attachment. This can be tested by unsending an attachment in iMessage and any clients are not notified of the change. If one client unsends it, then others will not see it removed.

This occurs on the latest release, 1.9.6, even with the new feature to include edit and unsends on the updated message event.

@cameronaaron
Copy link

bump

@zlshames
Copy link
Member

Do you know if this issue happens when individual attachments are sent, or only when multiple attachments are sent

@zlshames
Copy link
Member

Ok, i think i figured it out. When a message goes unsent, the messageInfoSummary gets updated like so:

[1]   messageSummaryInfo: [
[1]     { ust: true, retractedParts: [ 0 ], originalTextRange: [ 0, 62 ] }
[1]   ],

I just need to detect that

@joshuafhiggins
Copy link
Author

Do you know if this issue happens when individual attachments are sent, or only when multiple attachments are sent

Sorry for the late reply, it's both.

@zlshames
Copy link
Member

Fixed, my development branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants