Topic/ebsdlib memory crashing fixes #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last set of changes introduced memory leaks and crashes inside of the various CTF readers. This was caused by too much optimization and creating too much consistency to make the CTFReader look like the ANGReader even though the two readers are implemented in vastly different ways. + Removed test files that are no longer relevant + Removed other debugging statements from the H5EspritReader + Applied clang-tidy suggestions where possible to all of EBSDLib Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/ebsdlib-memory-crashing-fixes
branch
from
33a699a
to
0a7984e
Compare
Source/EbsdLib/HKL/CtfHeaderEntry.h
Outdated
| @@ -1,3 +1,7 @@ | |||
| #include <utility> | |||
|
|
|||
| #include <utility> | |||
There was a problem hiding this comment.
Only one #include <utility> required
mmarineBlueQuartz
requested changes
Jan 8, 2019
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…uctor Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
tplatt77
pushed a commit
to tplatt77/DREAM3D
that referenced
this pull request
Jan 14, 2019
* Fix memory leaks and crashing issues in EBSDLib for Oxford readers The last set of changes introduced memory leaks and crashes inside of the various CTF readers. This was caused by too much optimization and creating too much consistency to make the CTFReader look like the ANGReader even though the two readers are implemented in vastly different ways. + Removed test files that are no longer relevant + Removed other debugging statements from the H5EspritReader + Applied clang-tidy suggestions where possible to all of EBSDLib + Fix warnings about classes with virtual methods but non-virtual destructor Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.