Skip to content

Commit

Permalink
BUG: Fix parameter key for Import HDF5 Parameter (#953)
Browse files Browse the repository at this point in the history
- This will break any current Python codes that use this filter.

Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
  • Loading branch information
imikejackson committed May 8, 2024
1 parent db204c3 commit cee8ef7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Expand Up @@ -26,7 +26,7 @@ class SIMPLNXCORE_EXPORT ReadHDF5DatasetFilter : public IFilter
ReadHDF5DatasetFilter& operator=(ReadHDF5DatasetFilter&&) noexcept = delete;

// Parameter Keys
static inline constexpr StringLiteral k_ImportHDF5File_Key = "import_hd_f5_file";
static inline constexpr StringLiteral k_ImportHDF5File_Key = "import_hdf5_object";

/**
* @brief Reads SIMPL json and converts it simplnx Arguments.
Expand Down
2 changes: 1 addition & 1 deletion wrapping/python/docs/source/User_API.rst
Expand Up @@ -548,7 +548,7 @@ General Parameters
import_hdf5_param.datasets = [dataset1, dataset2]
# import_hdf5_param.parent = nx.DataPath(["Imported Data"])
result = nx.ReadHDF5DatasetFilter.execute(data_structure=data_structure,
import_hd_f5_file=import_hdf5_param
import_hdf5_object=import_hdf5_param
)
Expand Down
2 changes: 1 addition & 1 deletion wrapping/python/examples/scripts/import_hdf5.py
Expand Up @@ -85,7 +85,7 @@
# import_hdf5_param.parent = nx.DataPath(["Imported Data"])

result = nx.ReadHDF5DatasetFilter.execute(data_structure=data_structure,
import_hd_f5_file=import_hdf5_param
import_hdf5_object=import_hdf5_param
)
nxtest.check_filter_result(nx.ReadHDF5DatasetFilter, result)

0 comments on commit cee8ef7

Please sign in to comment.