Inquiry data truncated

[nielsmh]

Responses to standard (non-EVPD) Inquiry commands are truncated at 31 "additional data" bytes, meaning that the vendor-specific information (such as firmware revision) gets truncated, though the truncation might be happening in the ASPI driver on PC.

BlueSCSI-v2/lib/SCSI2SD/src/firmware/inquiry.c

Line 32 in 19633f4

0x1f, // standard length.

The additional data size field (index 4) should probably be updated somewhere before s2s_getStandardInquiry returns:

BlueSCSI-v2/lib/SCSI2SD/src/firmware/inquiry.c

Lines 270 to 276 in 19633f4

	if(cfg->deviceType != S2S_CFG_NETWORK && cfg->deviceType != S2S_CFG_ZIP100) {
	memcpy(&out[size], PLATFORM_INQUIRY, sizeof(PLATFORM_INQUIRY));
	size += sizeof(PLATFORM_INQUIRY);
	out[size] = PLATFORM_TOOLBOX_API;
	size += 1;
	}
	return size;

Additionally, the data in the PLATFORM_INQUIRY constant (that I currently can't read with software) seems to be 24 bytes long, but the Vendor-Specific field at offset 36 it gets written to is only specified to be 20 bytes long, meaning this code writes into reserved space as well.