ADD: tool to generate last mnemonic word #5722
Conversation
|
Can you please add tests to the PR. Maybe extract checkMnemonic logic to a separate function and write a unit test for it. Thank you for contributing to BlueWallet! |
|
@limpbrains I've moved the core logic to it's own file and added tests. Do you guys plan to ever review #5690 ? If so, I'll adapt it to use this helper instead of having this logic implemented twice. |
|
I've tried, works fine.
|
|
@limpbrains I've swapped the place of the result and the button, and added a message if the input is invalid. I also fixed a couple linter warnings i missed. Based on how the other tools are, I don't think it's necessary to describe the exact usage of the tool in the screen itself. If you want, maybe some kind of documentation? |
|
@Overtorment Do you think you could review this? |
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment |
There was a problem hiding this comment.
thanks for the contribution! merging this.
however, theres room for improvement, if you fancy doing a follow-up PR, most importantly, converting it to typescript (we now have a rule - every new file added might be in ts, while old js files are gradually converted)
| 'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon'; | ||
| const result = generateChecksumWords(input); | ||
| assert.ok(result); | ||
| assert.strictEqual(result.length, 8); |
There was a problem hiding this comment.
would be nice to check actual words generated
There was a problem hiding this comment.
logically it seems that if the right amount are generated and they're all valid, it's generated the right words
| } | ||
|
|
||
| const random = await randomBytes(1); | ||
| const randomindex = Math.round((random.readUInt8(0) / 255) * (possibleWords.length - 1)); |
There was a problem hiding this comment.
Math.random() might have worked better here, without this awkward buffer-to-int conversion (readUInt8(0) / 255). not a deal breaker tho
There was a problem hiding this comment.
I wasn't sure to what extent Math.random() was considered cryptographically secure in this project, and opted to use the safer RNG that i see used for other keygen purposes
| import * as bip39 from 'bip39'; | ||
| import createHash from 'create-hash'; | ||
|
|
||
| // partial (11 or 23 word) seed phrase |
There was a problem hiding this comment.
link to documentation would be nice
Closes #5680