FIX: BIometrics unlock #6080
Merged
FIX: BIometrics unlock #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overtorment
reviewed
Feb 3, 2024
| @@ -121,9 +121,9 @@ const UnlockWith = () => { | |||
| } | |||
|
|
|||
| setBiometricType(bt); | |||
| if (!biometricType || storageIsEncrypted) { | |||
There was a problem hiding this comment.
its a shame that this wasnt caught when it was initially merged.
also, i suppose TS would have caught this automatically
There was a problem hiding this comment.
i checked, it was me who "reviewed" and approved it: #6034
There was a problem hiding this comment.
I doubt TS would've caught this as the value and type are valid. just the wrong item being checked against
Overtorment
approved these changes
Feb 3, 2024
|
♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫ [android in browser] https://appetize.io/app/ojgbf5kym7cczptmpk6b5hhgbi?device=pixel4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.