Add LNURL payRequest #291
Add LNURL payRequest #291
Conversation
| let userid = await this._redis.get('userid_for_' + publicId); | ||
|
|
||
| if (userid) { | ||
| this._userid = userid; |
There was a problem hiding this comment.
shouldn't you also set this._publicid?
There was a problem hiding this comment.
Also, all the loadBy* methods should also fetch _publicid and store it in the _publicid.
| @@ -131,6 +149,21 @@ export class User { | |||
| if (config.bitcoind) return this._bitcoindrpc.request('importaddress', [address, address, false]); | |||
| } | |||
|
|
|||
| async getPublicId() { | |||
| if (!this._userid) return; | |||
There was a problem hiding this comment.
if this._publicid exists, it should probably return early.
| }); | ||
| } | ||
|
|
||
| const satAmount = req.query.amount / 1000; |
There was a problem hiding this comment.
Note: Currently the largest channel is 10 BTC, so in millisatoshis, that would fit within Number.MAX_SAFE_INTEGER, but keep in mind that once you pass 90071.99 BTC this will break in weird ways silently.
I am sure other parts of LNDHub assume all integers will be fine too... so this is probably not a problem worth fixing right now.
There was a problem hiding this comment.
Also, this should enforce the minSendable / maxSendable you return above.
Return an error if they try to request an amount outside the parameters.
| @@ -192,6 +205,71 @@ router.post('/addinvoice', postLimiter, async function (req, res) { | |||
| ); | |||
| }); | |||
|
|
|||
| router.get('/lnurlp/:publicid/qr', postLimiter, async function (req, res) { | |||
There was a problem hiding this comment.
| router.get('/lnurlp/:publicid/qr', postLimiter, async function (req, res) { | |
| router.get('/lnurlp/:publicid/qr', postLimiter, async function (req, res) { |
With this, Lightning addresses publicid@lndhub.io would be possible.
| } | ||
|
|
||
| logger.log('/publicid', [req.id, 'userid: ' + u.getUserId(), 'invoice: ' + req.body.invoice]); | ||
| res.send(await u.getPublicId()); |
There was a problem hiding this comment.
Also, you might want to return the public id in the response on account creation.
|
Can we make this feature happen? Would be the easiest way to get a lightning address on my node where I'm already using LNDhub 24/7 Will give 50 USD worth of sats to all five currrent participants when put into a release build, as a bounty. Obviously a way to figure out or set an accounts publicID in the clientside applications would be awesome too |
I think it has been communicated this repo won't merge any new features anymore. |
Wallet of Satoshi support this already: Then you can use https://lnurl.fiatjaf.com/codec/ to encode it to the clickable url like this:
(You can send part of the bounty to me 😉) |
|
Also BTCPay server supports this by POS app in printable QR codes mode and LN addresses in store settings. |
That's a true shame if true 😪 |
It’s true I’m closing this PR |
Them sunsetting the bluewallet node doesn't mean changes couldn't be merged for people who self host, though. |
It aims to add a LNURL payRequest for each BlueWallet user (BlueWallet requires some updates to implement this)
I added a new "key" named publicid to not reveal users id which are used in the secret string when creating a wallet