Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for creating Artisan commands. #35

Open
prplwtf opened this issue May 10, 2024 · 3 comments
Open

API for creating Artisan commands. #35

prplwtf opened this issue May 10, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@prplwtf
Copy link
Member

prplwtf commented May 10, 2024

No description provided.

@prplwtf prplwtf self-assigned this May 11, 2024
@prplwtf
Copy link
Member Author

prplwtf commented May 11, 2024

Implemented, requires testing.

@prplwtf prplwtf added the enhancement New feature or request label May 11, 2024
@prplwtf prplwtf changed the title (extensions) API for creating Artisan commands. API for creating Artisan commands. Jun 9, 2024
@prplwtf
Copy link
Member Author

prplwtf commented Jun 19, 2024

We might re-do the implementation as it's not how I want to be done. We might go for a Components.yml approach requiring commands to be registered in a Artisan.yml while Blueprint does it's magic and calls the command's functions.

For applying these changes, we could just steal a couple lines of code from the components script, with the added bonus of having to do less with sed as these commands should be able to live in isolated files instead of thrown into a component.

@prplwtf
Copy link
Member Author

prplwtf commented Jun 19, 2024

I'd love to receive some developer feedback on this to see which implementation would benefit developers (and users) the most. I'll try to maybe get a working version before next release, but no promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants