Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add calculate_distance_meters to estimate distance to a bluetooth device #28

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

Jc2k
Copy link
Contributor

@Jc2k Jc2k commented Sep 1, 2023

Add's the calculate_distance_meters helper from ibeacon_ble here so we can reuse it with out types of devices.

See home-assistant/core#99465.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (4634dfb) 99.44% compared to head (9f4e6c6) 99.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   99.44%   99.47%   +0.02%     
==========================================
  Files           3        4       +1     
  Lines         180      190      +10     
  Branches       25       27       +2     
==========================================
+ Hits          179      189      +10     
  Misses          1        1              
Files Changed Coverage Δ
src/bluetooth_data_tools/__init__.py 100.00% <100.00%> (ø)
src/bluetooth_data_tools/distance.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member

bdraco commented Sep 1, 2023

LGTM after lint fixed

@bdraco bdraco changed the title [feat] Add calculate_distance_meters to estimate distance to a bluetooth device feat: Add calculate_distance_meters to estimate distance to a bluetooth device Sep 1, 2023
@bdraco bdraco changed the title feat: Add calculate_distance_meters to estimate distance to a bluetooth device feat: add calculate_distance_meters to estimate distance to a bluetooth device Sep 1, 2023
@bdraco
Copy link
Member

bdraco commented Sep 1, 2023

Only the title actually matters since its going to squash

@bdraco bdraco merged commit c6f0150 into Bluetooth-Devices:main Sep 1, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants