Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid cythonizing SendReply #232

Merged
merged 8 commits into from
Aug 24, 2023
Merged

fix: avoid cythonizing SendReply #232

merged 8 commits into from
Aug 24, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 24, 2023

This is a workaround since context managers currently have an issue with Cython 3

fixes #229

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (ed5c87f) 82.58% compared to head (3fac7e3) 82.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   82.58%   82.71%   +0.12%     
==========================================
  Files          27       28       +1     
  Lines        3251     3257       +6     
  Branches      673      673              
==========================================
+ Hits         2685     2694       +9     
+ Misses        346      345       -1     
+ Partials      220      218       -2     
Files Changed Coverage Δ
src/dbus_fast/message_bus.py 71.63% <100.00%> (-0.30%) ⬇️
src/dbus_fast/send_reply.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title fix: avoid cythoning SendReply fix: avoid cythonizing SendReply Aug 24, 2023
@bdraco
Copy link
Member Author

bdraco commented Aug 24, 2023

Performance impact is effectively zero for Bluez DeviceFound messages since there is no reply

This seems like it will be fine.

Tested on production and no side effects observed (wouldn't expect it from moving code around)

@bdraco bdraco marked this pull request as ready for review August 24, 2023 14:28
@bdraco bdraco merged commit d12266d into main Aug 24, 2023
17 of 18 checks passed
@bdraco bdraco deleted the send_reply branch August 24, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cython's issue with python3.9 since dbus-fast v1.90.2
1 participant