-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handling of None messages from notify callback #236
Merged
bdraco
merged 12 commits into
Bluetooth-Devices:main
from
Mocramis:notify_callback_empty_message
Sep 7, 2023
Merged
fix: handling of None messages from notify callback #236
bdraco
merged 12 commits into
Bluetooth-Devices:main
from
Mocramis:notify_callback_empty_message
Sep 7, 2023
Commits on Sep 4, 2023
-
test(client): test early disconnect
The test does not fails but outputs the following erroneous logs: ERROR root:message_bus.py:1194 add match request failed. match="sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',path='/org/freedesktop/DBus',member='NameOwnerChanged'", WARNING root:message_bus.py:584 a message handler threw an exception on shutdown Traceback (most recent call last): File "/home/mocramis/misc/dbus-fast/src/dbus_fast/aio/message_reader.py", line 22, in _message_reader message = unmarshaller._unmarshall() File "/home/mocramis/misc/dbus-fast/src/dbus_fast/_private/unmarshaller.py", line 742, in _unmarshall self._read_header() File "/home/mocramis/misc/dbus-fast/src/dbus_fast/_private/unmarshaller.py", line 611, in _read_header self._read_to_pos(HEADER_SIGNATURE_SIZE) File "/home/mocramis/misc/dbus-fast/src/dbus_fast/_private/unmarshaller.py", line 366, in _read_to_pos self._read_sock_without_fds(pos) File "/home/mocramis/misc/dbus-fast/src/dbus_fast/_private/unmarshaller.py", line 329, in _read_sock_without_fds raise EOFError() EOFError During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/mocramis/misc/dbus-fast/src/dbus_fast/message_bus.py", line 582, in _finalize handler(None, err) File "/home/mocramis/misc/dbus-fast/src/dbus_fast/message_bus.py", line 737, in _reply_notify callback(reply, err) File "/home/mocramis/misc/dbus-fast/src/dbus_fast/message_bus.py", line 1197, in add_match_notify if msg.message_type == MessageType.ERROR: AttributeError: 'NoneType' object has no attribute 'message_type' However, trying to capture those logs seems to prevent the race condition from happening. Therefore, we just run the test for coverage.
Remy Noel committedSep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 2e5f27b - Browse repository at this point
Copy the full SHA 2e5f27bView commit details -
ci: increase pytest runtime to 10 seconds
previous added test pushed the testsuite above 5s on py38 ant py39/
Remy Noel committedSep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 119b27b - Browse repository at this point
Copy the full SHA 119b27bView commit details -
fix: handling of None messages from notify callback
This is especially common as BaseMessageBus._finalize calls handler(None, err) when an exception is raised.
Remy Noel committedSep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 3b4813a - Browse repository at this point
Copy the full SHA 3b4813aView commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8b071cf - Browse repository at this point
Copy the full SHA 8b071cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7226ca - Browse repository at this point
Copy the full SHA a7226caView commit details -
Configuration menu - View commit details
-
Copy full SHA for b771403 - Browse repository at this point
Copy the full SHA b771403View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cfd138 - Browse repository at this point
Copy the full SHA 1cfd138View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4e674 - Browse repository at this point
Copy the full SHA 7b4e674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e44979 - Browse repository at this point
Copy the full SHA 1e44979View commit details -
Merge branch 'notify_callback_empty_message' of https://github.com/Mo…
…cramis/dbus-fast into notify_callback_empty_message
Configuration menu - View commit details
-
Copy full SHA for 52c6abf - Browse repository at this point
Copy the full SHA 52c6abfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4a4cd7 - Browse repository at this point
Copy the full SHA b4a4cd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1da13ff - Browse repository at this point
Copy the full SHA 1da13ffView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.