Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: identification of IO Series 10 #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: identification of IO Series 10 #47

wants to merge 2 commits into from
+15 −0

Conversation

alvinchen1
Copy link

@Mitch73-2
Copy link

Is there any idea when these pull requests will be approved and integrated ?

Lash-L
Lash-L reviewed Feb 20, 2024
View reviewed changes
src/oralb_ble/parser.py
@@ -206,6 +211,7 @@ class ModelDescription:
b'\x03"': Models.SmartSeries8000,
b"\x03!": Models.SmartSeries9000,
b"\x061": Models.IOSeries89,
b"\x062k": Models.IOSeries10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will actually work. \x062k has a length of 3. When we use Bytes to model, we get the first 2 bytes. i.e. b"\x062" so it will still say it is Io Series 6/7.

@Mitch73-2
Copy link

I have no idea at all whether the following is possible (I have no code experience):

  • That a selection menu can be shown where you can select the IO Series10 yourself.

But this is just something that occurred to me as a figment of my imagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lash-L Lash-L Lash-L left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alvinchen1 @Mitch73-2 @Lash-L