Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current flow support #47

Closed
wants to merge 1 commit into from

Conversation

rajlaud
Copy link

@rajlaud rajlaud commented Apr 12, 2023

I have a new integration in the works (https://github.com/rajlaud/home-assistant/tree/victron-ble) that tracks a sensor that reports amp-hours. Would be great to add the appropriate units to sensor-state-data. The PR for the integration will add the units to Home Assistant core.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (a90039e) 94.16% compared to head (9baad2b) 94.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   94.16%   94.21%   +0.04%     
==========================================
  Files          12       12              
  Lines         463      467       +4     
  Branches       25       25              
==========================================
+ Hits          436      440       +4     
  Misses         26       26              
  Partials        1        1              
Impacted Files Coverage Δ
src/sensor_state_data/__init__.py 100.00% <100.00%> (ø)
src/sensor_state_data/library.py 100.00% <100.00%> (ø)
src/sensor_state_data/sensor/device_class.py 100.00% <100.00%> (ø)
src/sensor_state_data/units.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member

bdraco commented May 19, 2023

This one fall into the same category as this PR #51 (comment)

@rajlaud
Copy link
Author

rajlaud commented May 19, 2023

Sounds good, I'll follow that approach.

As strange as it may seem, amp-hours are a fairly common unit the boat/RV world, so it's possible that down the road another integration will want it. Can always revisit then.

@rajlaud rajlaud closed this May 19, 2023
@bdraco
Copy link
Member

bdraco commented May 20, 2023

Sounds good. Happy to revisit later if we have a lot of demand for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants