feat: add support for HT1 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 84.81% 87.61% +2.80%
==========================================
Files 2 2
Lines 79 113 +34
Branches 16 24 +8
==========================================
+ Hits 67 99 +32
- Misses 5 6 +1
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
ashleigh-hopkins
force-pushed
the
main
branch
4 times, most recently
from
0339acb
to
8e3a921
Compare
bdraco
reviewed
Dec 29, 2023
bdraco
reviewed
Dec 29, 2023
ashleigh-hopkins
force-pushed
the
main
branch
from
8e3a921
to
402bb07
Compare
|
Hey @bdraco I believe all comments have been addressed and I've added a couple more tests to improve the code coverage |
bdraco
reviewed
Dec 29, 2023
bdraco
reviewed
Dec 29, 2023
bdraco
reviewed
Dec 29, 2023
|
Looks good. I added a few more review comments above |
bdraco
reviewed
Dec 29, 2023
bdraco
reviewed
Dec 29, 2023
|
I ordered an HT1 to test with. Should be here sometime after the new year |
ashleigh-hopkins
force-pushed
the
main
branch
from
481415b
to
6d2df78
Compare
bdraco
reviewed
Dec 29, 2023
|
The ci is really out of date for this library. I'm going to need to fix that before this can be released |
bdraco
reviewed
Dec 29, 2023
bdraco
reviewed
Dec 29, 2023
bdraco
approved these changes
Dec 29, 2023
|
Thanks @ashleigh-hopkins |
|
https://pypi.org/project/sensorpush-ble/ 1.6.1 published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I reverse engineered the calculation for the HT1 and thought it might be useful for some people with this older device. Tested with the single HT1 I own (I also have a HT.w).
I wrote some tests, but I'm not actually sure how to execute them - I'm pretty new to python 😅
related issue home-assistant/core#76638