Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for HHCCJCY10 #21

Merged
merged 5 commits into from
Nov 12, 2022
Merged

feat: add support for HHCCJCY10 #21

merged 5 commits into from
Nov 12, 2022

Conversation

Jc2k
Copy link
Collaborator

@Jc2k Jc2k commented Oct 4, 2022

See home-assistant/home-assistant.io#24365.

Todo:

  • Double check case of service uuid
  • Check if there are predefined sensors to use instead now

I'll try and finish this tomorrow.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 46.48% // Head: 48.08% // Increases project coverage by +1.59% 🎉

Coverage data is based on head (22f9ed0) compared to base (db14912).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   46.48%   48.08%   +1.59%     
==========================================
  Files           4        4              
  Lines         712      782      +70     
  Branches      148      158      +10     
==========================================
+ Hits          331      376      +45     
- Misses        324      342      +18     
- Partials       57       64       +7     
Impacted Files Coverage Δ
src/xiaomi_ble/parser.py 46.99% <50.00%> (+1.58%) ⬆️
src/xiaomi_ble/__init__.py 100.00% <100.00%> (ø)
src/xiaomi_ble/const.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/xiaomi_ble/parser.py Outdated Show resolved Hide resolved
tests/test_parser.py Outdated Show resolved Hide resolved
@Ernst79
Copy link
Collaborator

Ernst79 commented Oct 4, 2022

Looks good to me.

@Ernst79 Ernst79 merged commit 0f387c2 into main Nov 12, 2022
@Ernst79 Ernst79 deleted the HHCCJCY10 branch November 12, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants