Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:689495] [RFC,v2,08/31] timers: Bluetooth: Use del_timer_shutdown() before freeing timer #1185

Closed
wants to merge 2 commits into from
Closed

[PW_SID:689495] [RFC,v2,08/31] timers: Bluetooth: Use del_timer_shutdown() before freeing timer #1185

wants to merge 2 commits into from

Conversation

BluezTestBot
Copy link
Owner

From: "Steven Rostedt (Google)" rostedt@goodmis.org

Before a timer is freed, del_timer_shutdown() must be called.

Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/

Cc: Marcel Holtmann marcel@holtmann.org
Cc: Johan Hedberg johan.hedberg@gmail.com
Cc: Luiz Augusto von Dentz luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Signed-off-by: Steven Rostedt (Google) rostedt@goodmis.org

drivers/bluetooth/hci_bcsp.c | 2 +-
drivers/bluetooth/hci_h5.c | 2 +-
drivers/bluetooth/hci_qca.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)

tedd-an and others added 2 commits October 27, 2022 14:50
@tedd-an @BluezTestBot
workflow: Add workflow files for ci
7e58c6d 
This patch adds workflow files for ci:

[schedule_work.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
@rostedt @BluezTestBot
timers: Bluetooth: Use del_timer_shutdown() before freeing timer
e200274 
Before a timer is freed, del_timer_shutdown() must be called.

Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/

Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
@github-actions
Copy link

CheckPatch
Test ID: checkpatch
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Duration: 1.71 seconds
Result: PASS

@github-actions
Copy link

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.85 seconds
Result: PASS

@github-actions
Copy link

SubjectPrefix
Test ID: subjectprefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.74 seconds
Result: PASS

@github-actions
Copy link

BuildKernel
Test ID: buildkernel
Desc: Build Kernel with minimal configuration supports Bluetooth
Duration: 25.46 seconds
Result: FAIL
Output:

drivers/bluetooth/hci_bcsp.c: In function ‘bcsp_close’:
drivers/bluetooth/hci_bcsp.c:740:2: error: implicit declaration of function ‘del_timer_shutdown’; did you mean ‘device_shutdown’? [-Werror=implicit-function-declaration]
  740 |  del_timer_shutdown(&bcsp->tbcsp);
      |  ^~~~~~~~~~~~~~~~~~
      |  device_shutdown
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:249: drivers/bluetooth/hci_bcsp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:465: drivers/bluetooth] Error 2
make: *** [Makefile:1852: drivers] Error 2

@github-actions
Copy link

BuildKernel32
Test ID: buildkernel32
Desc: Build 32bit Kernel with minimal configuration supports Bluetooth
Duration: 22.13 seconds
Result: FAIL
Output:

drivers/bluetooth/hci_bcsp.c: In function ‘bcsp_close’:
drivers/bluetooth/hci_bcsp.c:740:2: error: implicit declaration of function ‘del_timer_shutdown’; did you mean ‘device_shutdown’? [-Werror=implicit-function-declaration]
  740 |  del_timer_shutdown(&bcsp->tbcsp);
      |  ^~~~~~~~~~~~~~~~~~
      |  device_shutdown
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:249: drivers/bluetooth/hci_bcsp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:465: drivers/bluetooth] Error 2
make: *** [Makefile:1852: drivers] Error 2

@github-actions
Copy link

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.33 seconds
Result: SKIP
Output:

buildkernel failed

@github-actions
Copy link

TestRunner: Setup
Test ID: testrunnersetup
Desc: Setup environment for running Test Runner
Duration: 504.34 seconds
Result: PASS

@github-actions
Copy link

TestRunner: l2cap-tester
Test ID: testrunnerl2cap-tester
Desc: Run test-runner with l2cap-tester
Duration: 17.14 seconds
Result: PASS
Output:

Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: iso-tester
Test ID: testrunneriso-tester
Desc: Run test-runner with iso-tester
Duration: 16.04 seconds
Result: PASS
Output:

Total: 55, Passed: 55 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: bnep-tester
Test ID: testrunnerbnep-tester
Desc: Run test-runner with bnep-tester
Duration: 6.22 seconds
Result: PASS
Output:

Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: mgmt-tester
Test ID: testrunnermgmt-tester
Desc: Run test-runner with mgmt-tester
Duration: 103.02 seconds
Result: PASS
Output:

Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: rfcomm-tester
Test ID: testrunnerrfcomm-tester
Desc: Run test-runner with rfcomm-tester
Duration: 9.87 seconds
Result: PASS
Output:

Total: 11, Passed: 11 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: sco-tester
Test ID: testrunnersco-tester
Desc: Run test-runner with sco-tester
Duration: 9.36 seconds
Result: PASS
Output:

Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: ioctl-tester
Test ID: testrunnerioctl-tester
Desc: Run test-runner with ioctl-tester
Duration: 10.57 seconds
Result: PASS
Output:

Total: 28, Passed: 28 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: mesh-tester
Test ID: testrunnermesh-tester
Desc: Run test-runner with mesh-tester
Duration: 7.67 seconds
Result: PASS
Output:

Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: smp-tester
Test ID: testrunnersmp-tester
Desc: Run test-runner with smp-tester
Duration: 9.43 seconds
Result: PASS
Output:

Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: userchan-tester
Test ID: testrunneruserchan-tester
Desc: Run test-runner with userchan-tester
Duration: 6.53 seconds
Result: PASS
Output:

Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

@github-actions github-actions bot force-pushed the workflow branch 11 times, most recently from fcb45b0 to aa3568e Compare October 28, 2022 05:08
@github-actions github-actions bot force-pushed the workflow branch 26 times, most recently from 8a8a150 to 3f171b7 Compare November 17, 2022 23:39
@tedd-an tedd-an force-pushed the workflow branch 2 times, most recently from b4573ad to 8433d56 Compare November 18, 2022 00:06
@BluezTestBot BluezTestBot deleted the 689495 branch November 18, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@BluezTestBot @tedd-an @rostedt