Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:550611] [v3] bluetooth: Fix Advertisement Monitor Suspend/Resume #512

Closed
wants to merge 2 commits into from

Conversation

BluezTestBot
Copy link
Owner

During system suspend, advertisement monitoring is disabled by setting
the HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable to False. This
disables the monitoring during suspend, however, if the controller is
monitoring a device, it sends HCI_VS_MSFT_LE_Monitor_Device_Event to
indicate that the monitoring has been stopped for that particular
device. This event may occur after suspend depending on the
low_threshold_timeout and peer device advertisement frequency, which
causes early wake up.

Right way to disable the monitoring for suspend is by removing all the
monitors before suspend and re-monitor after resume to ensure no events
are received during suspend. This patch fixes this suspend/resume issue.

Following tests are performed:

  • Add monitors before suspend and make sure DeviceFound gets triggered
  • Suspend the system and verify that all monitors are removed by kernel
    but not Released by bluetoothd
  • Wake up and verify that all monitors are added again and DeviceFound
    gets triggered

Signed-off-by: Manish Mandlik mmandlik@google.com
Reviewed-by: Archie Pusaka apusaka@google.com
Reviewed-by: Miao-chen Chou mcchou@google.com

tedd-an and others added 2 commits September 21, 2021 21:33
This patch adds workflow files for ci:

[schedule_work.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
During system suspend, advertisement monitoring is disabled by setting
the HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable to False. This
disables the monitoring during suspend, however, if the controller is
monitoring a device, it sends HCI_VS_MSFT_LE_Monitor_Device_Event to
indicate that the monitoring has been stopped for that particular
device. This event may occur after suspend depending on the
low_threshold_timeout and peer device advertisement frequency, which
causes early wake up.

Right way to disable the monitoring for suspend is by removing all the
monitors before suspend and re-monitor after resume to ensure no events
are received during suspend. This patch fixes this suspend/resume issue.

Following tests are performed:
- Add monitors before suspend and make sure DeviceFound gets triggered
- Suspend the system and verify that all monitors are removed by kernel
  but not Released by bluetoothd
- Wake up and verify that all monitors are added again and DeviceFound
  gets triggered

Signed-off-by: Manish Mandlik <mmandlik@google.com>
Reviewed-by: Archie Pusaka <apusaka@google.com>
Reviewed-by: Miao-chen Chou <mcchou@google.com>
@github-actions
Copy link

CheckPatch
Test ID: checkpatch
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Duration: 2.00 seconds
Result: PASS

@github-actions
Copy link

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 1.00 seconds
Result: FAIL
Output:

[v3] bluetooth: Fix Advertisement Monitor Suspend/Resume
2: B4 Second line is not empty: "the HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable to False. This"

@github-actions
Copy link

BuildKernel
Test ID: buildkernel
Desc: Build Kernel with minimal configuration supports Bluetooth
Duration: 533.75 seconds
Result: PASS

@github-actions
Copy link

TestRunner: Setup
Test ID: testrunnersetup
Desc: Setup environment for running Test Runner
Duration: 350.97 seconds
Result: FAIL
Output:

Unable to build Kernel image for tester

@github-actions github-actions bot force-pushed the workflow branch 24 times, most recently from 39b729d to 54a2554 Compare September 22, 2021 23:38
@github-actions github-actions bot force-pushed the workflow branch 28 times, most recently from 0b6753b to a38baf4 Compare September 27, 2021 21:34
@BluezTestBot BluezTestBot deleted the 550611 branch September 27, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants