Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:556109] [PATCHv2] Bluetooth: quirk disabling LE Read Transmit Power #544

Closed
wants to merge 3 commits into from

Conversation

BluezTestBot
Copy link
Owner

The LE Read Transmit Power command is Advertised on some Broadcom
controlers, but not supported. Using this command breaks Bluetooth
on the MacBookPro16,1 and iMac20,1. Added a quirk disabling LE Read
Transmit Power for these devices, based off their common chip id 150.

Link: https://lore.kernel.org/r/4970a940-211b-25d6-edab-21a815313954@protonmail.com
Signed-off-by: Orlando Chamberlain redecorating@protonmail.com

Vudentz and others added 3 commits October 1, 2021 22:33
prevent_wake logic is backward since what it is really checking is
if the device may wakeup the system or not, not that it will prevent
the to be awaken.

Also looking on how other subsystems have the entry as power/wakeup
this also renames the force_prevent_wake to force_wakeup in vhci driver.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
This patch adds workflow files for ci:

[schedule_work.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
The LE Read Transmit Power command is Advertised on some Broadcom
controlers, but not supported. Using this command breaks Bluetooth
on the MacBookPro16,1 and iMac20,1. Added a quirk disabling LE Read
Transmit Power for these devices, based off their common chip id 150.

Link: https://lore.kernel.org/r/4970a940-211b-25d6-edab-21a815313954@protonmail.com
Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

CheckPatch
Test ID: checkpatch
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Duration: 1.74 seconds
Result: FAIL
Output:

[PATCHv2] Bluetooth: quirk disabling LE Read Transmit Power\CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#117: FILE: net/bluetooth/hci_core.c:746:
+		if (hdev->commands[38] & 0x80 &&
+			!test_bit(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER, &hdev->quirks)) {

total: 0 errors, 0 warnings, 1 checks, 36 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12529889.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.89 seconds
Result: FAIL
Output:

[PATCHv2] Bluetooth: quirk disabling LE Read Transmit Power
8: B1 Line exceeds max length (83>80): "Link: https://lore.kernel.org/r/4970a940-211b-25d6-edab-21a815313954@protonmail.com"

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

BuildKernel
Test ID: buildkernel
Desc: Build Kernel with minimal configuration supports Bluetooth
Duration: 461.55 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: Setup
Test ID: testrunnersetup
Desc: Setup environment for running Test Runner
Duration: 339.63 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: l2cap-tester
Test ID: testrunnerl2cap-tester
Desc: Run test-runner with l2cap-tester
Duration: 7.43 seconds
Result: PASS
Output:

Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: bnep-tester
Test ID: testrunnerbnep-tester
Desc: Run test-runner with bnep-tester
Duration: 4.27 seconds
Result: PASS
Output:

Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: mgmt-tester
Test ID: testrunnermgmt-tester
Desc: Run test-runner with mgmt-tester
Duration: 73.53 seconds
Result: FAIL
Output:

Total: 458, Passed: 455 (99.3%), Failed: 3, Not Run: 0

Failed Test Cases
Suspend/Resume - Success 1 (Suspend)                 Failed       0.089 seconds
Suspend/Resume - Success 3 (Device in WL)            Failed       0.088 seconds
Suspend/Resume - Success 4 (Advertising)             Failed       0.097 seconds

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: rfcomm-tester
Test ID: testrunnerrfcomm-tester
Desc: Run test-runner with rfcomm-tester
Duration: 5.37 seconds
Result: PASS
Output:

Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: sco-tester
Test ID: testrunnersco-tester
Desc: Run test-runner with sco-tester
Duration: 5.75 seconds
Result: PASS
Output:

Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: smp-tester
Test ID: testrunnersmp-tester
Desc: Run test-runner with smp-tester
Duration: 5.40 seconds
Result: PASS
Output:

Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

TestRunner: userchan-tester
Test ID: testrunneruserchan-tester
Desc: Run test-runner with userchan-tester
Duration: 4.57 seconds
Result: PASS
Output:

Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

@github-actions github-actions bot force-pushed the workflow branch 16 times, most recently from 02194a5 to cd82b54 Compare October 2, 2021 15:38
@github-actions github-actions bot force-pushed the workflow branch 28 times, most recently from 447b394 to aa915f4 Compare October 31, 2021 09:38
@BluezTestBot BluezTestBot deleted the 556109 branch October 31, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants