Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:568845] bluetooth: don't write directly to netdev->dev_addr #588

Closed
wants to merge 3 commits into from
Closed

[PW_SID:568845] bluetooth: don't write directly to netdev->dev_addr #588

wants to merge 3 commits into from

Conversation

BluezTestBot
Copy link
Owner

The usual conversions.

These are intended to be merged to net-next directly,
because bluetooth tree is missing one of the pre-req
changes at the moment.

v2: s/got/go/

Jakub Kicinski (2):
bluetooth: use eth_hw_addr_set()
bluetooth: use dev_addr_set()

net/bluetooth/6lowpan.c | 4 +++-
net/bluetooth/bnep/core.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)

tedd-an and others added 3 commits October 22, 2021 22:39
@tedd-an @BluezTestBot
workflow: Add workflow files for ci
6a0761e 
This patch adds workflow files for ci:

[schedule_work.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
@kuba-moo @BluezTestBot
bluetooth: use eth_hw_addr_set()
c9488cd 
Commit 406f42f ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it go through appropriate helpers.

Convert bluetooth from memcpy(... ETH_ADDR) to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - memcpy(dev->dev_addr, np, ETH_ALEN)
  + eth_hw_addr_set(dev, np)

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Marcel Holtmann <marcel@holtmann.org>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
@kuba-moo @BluezTestBot
bluetooth: use dev_addr_set()
74ce5ab 
Commit 406f42f ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it go through appropriate helpers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Marcel Holtmann <marcel@holtmann.org>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
@github-actions
Copy link

CheckPatch
Test ID: checkpatch
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Duration: 1.47 seconds
Result: PASS

@github-actions
Copy link

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.64 seconds
Result: PASS

@github-actions
Copy link

BuildKernel
Test ID: buildkernel
Desc: Build Kernel with minimal configuration supports Bluetooth
Duration: 583.78 seconds
Result: FAIL
Output:

net/bluetooth/6lowpan.c: In function ‘setup_netdev’:
net/bluetooth/6lowpan.c:677:25: error: passing argument 2 of ‘__dev_addr_set’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  677 |  __dev_addr_set(netdev, &addr, sizeof(addr));
      |                         ^~~~~
      |                         |
      |                         bdaddr_t * {aka struct <anonymous> *}
In file included from ./include/uapi/linux/if_arp.h:27,
                 from ./include/linux/if_arp.h:23,
                 from net/bluetooth/6lowpan.c:7:
./include/linux/netdevice.h:4645:50: note: expected ‘const u8 *’ {aka ‘const unsigned char *’} but argument is of type ‘bdaddr_t *’ {aka ‘struct <anonymous> *’}
 4645 | __dev_addr_set(struct net_device *dev, const u8 *addr, size_t len)
      |                                        ~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:277: net/bluetooth/6lowpan.o] Error 1
make[1]: *** [scripts/Makefile.build:540: net/bluetooth] Error 2
make: *** [Makefile:1868: net] Error 2

@github-actions
Copy link

TestRunner: Setup
Test ID: testrunnersetup
Desc: Setup environment for running Test Runner
Duration: 464.82 seconds
Result: PASS

@github-actions
Copy link

TestRunner: l2cap-tester
Test ID: testrunnerl2cap-tester
Desc: Run test-runner with l2cap-tester
Duration: 10.27 seconds
Result: PASS
Output:

Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: bnep-tester
Test ID: testrunnerbnep-tester
Desc: Run test-runner with bnep-tester
Duration: 5.34 seconds
Result: PASS
Output:

Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: mgmt-tester
Test ID: testrunnermgmt-tester
Desc: Run test-runner with mgmt-tester
Duration: 95.80 seconds
Result: FAIL
Output:

Total: 468, Passed: 463 (98.9%), Failed: 5, Not Run: 0

Failed Test Cases
Read Ext Controller Info 1                           Failed       0.112 seconds
Read Ext Controller Info 2                           Failed       0.126 seconds
Read Ext Controller Info 3                           Failed       0.113 seconds
Read Ext Controller Info 4                           Failed       0.119 seconds
Read Ext Controller Info 5                           Failed       0.149 seconds

@github-actions
Copy link

TestRunner: rfcomm-tester
Test ID: testrunnerrfcomm-tester
Desc: Run test-runner with rfcomm-tester
Duration: 6.62 seconds
Result: PASS
Output:

Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: sco-tester
Test ID: testrunnersco-tester
Desc: Run test-runner with sco-tester
Duration: 6.82 seconds
Result: PASS
Output:

Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: smp-tester
Test ID: testrunnersmp-tester
Desc: Run test-runner with smp-tester
Duration: 6.67 seconds
Result: PASS
Output:

Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

TestRunner: userchan-tester
Test ID: testrunneruserchan-tester
Desc: Run test-runner with userchan-tester
Duration: 5.67 seconds
Result: PASS
Output:

Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

@github-actions github-actions bot force-pushed the workflow branch 16 times, most recently from 52f46e4 to 1c135de Compare October 23, 2021 16:57
@github-actions github-actions bot force-pushed the workflow branch 28 times, most recently from 445ede9 to ba9840d Compare October 25, 2021 20:39
@BluezTestBot BluezTestBot deleted the 568845 branch October 25, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@BluezTestBot @tedd-an @kuba-moo