[PW_SID:553055] gatt: remove superfluous extended properties #1008
Conversation
This patch adds workflow files for ci:
[schedule_work.yml]
- runs every 30 mins.
- sync repo with upstream repo and rebase workflow branch to tip of
master.
- creates PR after reading patches from patchwork.kernel.org
[ci.yml]
- Tests the following checks:
- checkpatch
- gitlint
- make
- make check
[code_scan.yml]
- Static code checker: Coverity and Clang
- Coverity: Submit the result to the coverity website
- Clang Code Scan: Send email with result file to the internal team
To simplify the history, new change will amend to this patch without
creating new patch.
BlueZ contained superfluous properties that not only did nothing of value, but needlessly created CEP descriptors for any characteristic with a secure/encrypted/authenticated flag applied to it. This actually deviated from the spec(Bluetooth core 5.3, 3.3.3.1) by setting the reserved bits in the CEPD.
|
CheckPatch |
|
GitLint |
|
Prep - Setup ELL |
|
Build - Prep |
|
Build - Configure |
|
Build - Make |
|
Make Check |
|
Make Distcheck |
|
Build w/ext ELL - Configure |
|
Build w/ext ELL - Make |
github-actions
bot
force-pushed
the
workflow
branch
from
e6ed6d1
to
a2bd70a
Compare
As discussed on Slack, the BlueZ source contains superfluous
non-standard extended properties with no effect other than the creation
of unnecessary CEPDs with bits set in the "reserved" field. These
extended properties are set when a characteristic has a
secure-*,encrypt-*, orencrypt-authenticated-*flag set.According to section 3.3.3.1 of the Bluetooth core spec 5.3, the only
valid extended properties are "reliable write", and "writable
auxiliaries."
This patch removes all other extended properties.
Dagan Martinez (1):
gatt: remove superfluous extended properties