Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:651141] [BlueZ,1/3] doc/mgmt-api: Update for Add Extended Advertisement Command #1307

Closed
wants to merge 4 commits into from

Conversation

BluezTestBot
Copy link
Owner

From: Tedd Ho-Jeong An tedd.an@intel.com

This patch aligns the input parameter for Add Extended Advertisement
command with actual data struct and add missing flag descriptions.

doc/mgmt-api.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

This patch adds workflow files for ci:

[schedule_work.yml]
  - runs every 30 mins.
  - sync repo with upstream repo and rebase workflow branch to tip of
    master.
  - creates PR after reading patches from patchwork.kernel.org

[ci.yml]
  - Tests the following checks:
    - checkpatch
    - gitlint
    - make
    - make check

[code_scan.yml]
    - Static code checker: Coverity and Clang
    - Coverity: Submit the result to the coverity website
    - Clang Code Scan: Send email with result file to the internal team

To simplify the history, new change will amend to this patch without
creating new patch.
This patch aligns the input parameter for Add Extended Advertisement
command with actual data struct and add missing flag descriptions.
This patch updates the missing flag details for Advertisement flags

@ MGMT Event: Command Complete (0x0001) plen 11
      Read Advertising Features (0x003d) plen 8
        Status: Success (0x00)
        Flags: 0x0001ffff
	...
          Unknown advertising flag (0x00010c00)
	...
This patch adds new command to support the following MGMT API:
 Add Extended Advertising Parameters Command
 Add Extended Advertising Data Command
@BluezTestBot
Copy link
Owner Author

CheckPatch
Test ID: checkpatch
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Duration: 3.59 seconds
Result: FAIL

Output:

[BlueZ,3/3] tools/btmgmt: Add support Add Ext Adv command
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#233: FILE: tools/btmgmt.c:5031:
+			/* fall through */

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#405: FILE: tools/btmgmt.c:5203:
+			/* fall through */

/github/workspace/src/12884720.patch total: 0 errors, 2 warnings, 389 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12884720.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

@BluezTestBot
Copy link
Owner Author

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 2.34 seconds
Result: FAIL

Output:

[BlueZ,2/3] monitor: Update flag information for Extended Advertismement
11: B3 Line contains hard tab characters (\t): "	..."
13: B3 Line contains hard tab characters (\t): "	..."

@BluezTestBot
Copy link
Owner Author

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 51.57 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Prep
Test ID: buildprep
Desc: Prepare environment for build
Duration: 0.63 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 10.34 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Make
Test ID: buildmake
Desc: Build the BlueZ source tree
Duration: 1503.91 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 12.39 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 540.37 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 282.70 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build w/ext ELL - Configure
Test ID: build_extell
Desc: Configure BlueZ source with '--enable-external-ell' configuration
Duration: 10.49 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build w/ext ELL - Make
Test ID: build_extell_make
Desc: Build BlueZ source with '--enable-external-ell' configuration
Duration: 1443.36 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 4517.59 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants