[PW_SID:668224] [BlueZ,v2,1/2] hog-lib: Don't restrict Report MAP size #1364
Conversation
Although HIDS spec is quite clear the Report MAP shall be limited to 512 bytes it doesn't seem OS do enforce that on the profile/client side and since there isn't any qualification test enforcing it either there are quite many devices which uses Report MAP bigger that 512 bytes (e.g.: Brydge W-Touch and Lenovo Duet 3 BT Folio). bluez#377
This fixes the following errors:
profiles/input/hog-lib.c:600:19: warning: Access to field 'handle'
results in a dereference of a null pointer (loaded from variable 'chr')
report->handle = chr->handle;
^~~~~~~~~~~
profiles/input/hog-lib.c:637:11: warning: Access to field 'value_handle'
results in a dereference of a null pointer (loaded from variable 'chr')
start = chr->value_handle + 1;
^~~~~~~~~~~~~~~~~
profiles/input/hog-lib.c:1240:11: warning: Access to field 'value_handle'
results in a dereference of a null pointer (loaded from variable 'chr')
start = chr->value_handle + 1;
^~~~~~~~~~~~~~~~~
|
CheckPatch |
|
GitLint |
|
Prep - Setup ELL |
|
Build - Prep |
|
Build - Configure |
|
Build - Make |
|
Make Check |
|
Make Check w/Valgrind |
|
Make Distcheck |
|
Build w/ext ELL - Configure |
|
Build w/ext ELL - Make |
|
Incremental Build w/ patches |
|
Scan Build |
From: Luiz Augusto von Dentz luiz.von.dentz@intel.com
Although HIDS spec is quite clear the Report MAP shall be limited to
512 bytes it doesn't seem OS do enforce that on the profile/client side
and since there isn't any qualification test enforcing it either there
are quite many devices which uses Report MAP bigger that 512 bytes
(e.g.: Brydge W-Touch and Lenovo Duet 3 BT Folio).
bluez#377
profiles/input/hog-lib.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)