Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:676220] Volume Control Profile #1401

Closed
wants to merge 5 commits into from
Closed

[PW_SID:676220] Volume Control Profile #1401

wants to merge 5 commits into from

Conversation

BluezTestBot
Copy link
Owner

This adds Volume Control Service UUIDs which will be used by
Volume Control Profile.

lib/uuid.h | 7 +++++++
1 file changed, 7 insertions(+)

tedd-an and others added 5 commits September 8, 2022 21:47
@tedd-an @BluezTestBot
workflow: Add workflow files
e783769 
This patch adds workflow files for ci:

[schedule_work.yml]
  - runs every 30 mins.
  - sync repo with upstream repo and rebase workflow branch to tip of
    master.
  - creates PR after reading patches from patchwork.kernel.org

[ci.yml]
  - Tests the following checks:
    - checkpatch
    - gitlint
    - make
    - make check

[code_scan.yml]
    - Static code checker: Coverity and Clang
    - Coverity: Submit the result to the coverity website
    - Clang Code Scan: Send email with result file to the internal team

To simplify the history, new change will amend to this patch without
creating new patch.
@sathishnarasimman @BluezTestBot
lib/uuid: Add VCS UUIDs
f057e68 
This adds Volume Control Service UUIDs which will be used by
Volume Control Profile.
@sathishnarasimman @BluezTestBot
shared/vcp: Add initial code for handling VCP
a1a1290 
This adds initial code for Volume Control Profile.
@sathishnarasimman @BluezTestBot
profiles: Add initial code for vcp plugin
df41a06 
This adds initial code for vcp plugin which handles Volume Control
Profile and Volume Control Service.
@sathishnarasimman @BluezTestBot
monitor/att: Add decoding support for Volume Control Serice
6933207 
This adds decoding support for VCS attributes

> ACL Data RX: Handle 3585 flags 0x02 dlen 7
      ATT: Read Request (0x0a) len 2
        Handle: 0x0017 Type: Volume State (0x2b7d)
< ACL Data TX: Handle 3585 flags 0x00 dlen 8
      ATT: Read Response (0x0b) len 3
        Value: 000000
        Handle: 0x0017 Type: Volume State (0x2b7d)
            Volume Setting: 0
            Not Muted: 0
            Change Counter: 0
> HCI Event: Number of Completed Packets (0x13) plen 5
        Num handles: 1
        Handle: 3585 Address: 49:71:FC:C0:66:C6 (Resolvable)
        Count: 1
> ACL Data RX: Handle 3585 flags 0x02 dlen 7
      ATT: Read Request (0x0a) len 2
        Handle: 0x001c Type: Volume Flags (0x2b7f)
< ACL Data TX: Handle 3585 flags 0x00 dlen 6
      ATT: Read Response (0x0b) len 1
        Value: 01
        Handle: 0x001c Type: Volume Flags (0x2b7f)
            Volume Falg: 1
@BluezTestBot
Copy link
Owner Author

CheckPatch
Test ID: checkpatch
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Duration: 5.79 seconds
Result: FAIL

Output:

[BlueZ,2/4] shared/vcp: Add initial code for handling VCP
WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#393: FILE: src/shared/vcp.c:302:
+	gatt_db_attribute_notify(vdb->vcs->vs, (void *)vstate, sizeof(struct vol_state),

WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#425: FILE: src/shared/vcp.c:334:
+	gatt_db_attribute_notify(vdb->vcs->vs, (void *)vstate, sizeof(struct vol_state),

WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#458: FILE: src/shared/vcp.c:367:
+	gatt_db_attribute_notify(vdb->vcs->vs, (void *)vstate, sizeof(struct vol_state),

WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#491: FILE: src/shared/vcp.c:400:
+	gatt_db_attribute_notify(vdb->vcs->vs, (void *)vstate, sizeof(struct vol_state),

WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#523: FILE: src/shared/vcp.c:432:
+	gatt_db_attribute_notify(vdb->vcs->vs, (void *)vstate, sizeof(struct vol_state),

WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#555: FILE: src/shared/vcp.c:464:
+	gatt_db_attribute_notify(vdb->vcs->vs, (void *)vstate, sizeof(struct vol_state),

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#1051: FILE: src/shared/vcp.c:960:
+						value_handle, vcp_vstate_register,

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#1080: FILE: src/shared/vcp.c:989:
+						value_handle, vcp_vflag_register,

WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#1146: FILE: src/shared/vcp.h:16:
+#define __packed __attribute__((packed))

/github/workspace/src/12973630.patch total: 0 errors, 9 warnings, 1098 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12973630.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

[BlueZ,3/4] profiles: Add initial code for vcp plugin
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#395: FILE: profiles/audio/vcp.c:288:
+static unsigned int vcp_id = 0;

/github/workspace/src/12973633.patch total: 1 errors, 0 warnings, 330 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12973633.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

@BluezTestBot
Copy link
Owner Author

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 3.00 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 31.92 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Prep
Test ID: buildprep
Desc: Prepare environment for build
Duration: 0.90 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 9.87 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Make
Test ID: buildmake
Desc: Build the BlueZ source tree
Duration: 1165.82 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 12.98 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 355.07 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 306.75 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build w/ext ELL - Configure
Test ID: build_extell
Desc: Configure BlueZ source with '--enable-external-ell' configuration
Duration: 10.50 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build w/ext ELL - Make
Test ID: build_extell_make
Desc: Build BlueZ source with '--enable-external-ell' configuration
Duration: 107.90 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Incremental Build w/ patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 510.36 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Scan Build
Test ID: scan_build
Desc: Run Scan Build with patches
Duration: 1238.26 seconds
Result: WARNING

Output:

*****************************************************************************
The bugs reported by the scan-build may or may not be caused by your patches.
Please check the list and fix the bugs if they are caused by your patch.
*****************************************************************************
src/shared/vcp.c:288:11: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
        vstate = vdb->vcs->vstate;
                 ^~~~~~~~
src/shared/vcp.c:294:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
        if (*change_counter != vstate->counter) {
                               ^~~~~~~~~~~~~~~
src/shared/vcp.c:320:11: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
        vstate = vdb->vcs->vstate;
                 ^~~~~~~~
src/shared/vcp.c:326:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
        if (*change_counter != vstate->counter) {
                               ^~~~~~~~~~~~~~~
src/shared/vcp.c:352:11: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
        vstate = vdb->vcs->vstate;
                 ^~~~~~~~
src/shared/vcp.c:358:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
        if (*change_counter != vstate->counter) {
                               ^~~~~~~~~~~~~~~
src/shared/vcp.c:385:11: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
        vstate = vdb->vcs->vstate;
                 ^~~~~~~~
src/shared/vcp.c:391:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
        if (*change_counter != vstate->counter) {
                               ^~~~~~~~~~~~~~~
src/shared/vcp.c:418:11: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
        vstate = vdb->vcs->vstate;
                 ^~~~~~~~
src/shared/vcp.c:424:29: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
        if (req->change_counter != vstate->counter) {
                                   ^~~~~~~~~~~~~~~
src/shared/vcp.c:450:11: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
        vstate = vdb->vcs->vstate;
                 ^~~~~~~~
src/shared/vcp.c:456:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
        if (*change_counter != vstate->counter) {
                               ^~~~~~~~~~~~~~~
src/shared/vcp.c:482:11: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
        vstate = vdb->vcs->vstate;
                 ^~~~~~~~
src/shared/vcp.c:488:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
        if (*change_counter != vstate->counter) {
                               ^~~~~~~~~~~~~~~
14 warnings generated.

@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 46eb356 to 2468e51 Compare September 19, 2022 22:48
@github-actions github-actions bot force-pushed the workflow branch 7 times, most recently from 6e278ce to cfe2660 Compare September 27, 2022 19:47
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from adccbfb to c84b866 Compare October 4, 2022 02:31
@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from 9335702 to fec2b58 Compare October 10, 2022 21:29
@BluezTestBot BluezTestBot deleted the 676220 branch October 12, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BluezTestBot @tedd-an @sathishnarasimman