Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:690159] To add support for Metadata, CID, VID #1469

Closed
wants to merge 6 commits into from
Closed

[PW_SID:690159] To add support for Metadata, CID, VID #1469

wants to merge 6 commits into from

Conversation

BluezTestBot
Copy link
Owner

This adds fixes for handing for Company ID and Vendor Codec ID
while adding PAC record to database and responding to Attribute
Read Request for Sink/Source PAC Characteristics.

src/shared/bap.c | 5 +++++
src/shared/bap.h | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)

tedd-an and others added 6 commits October 25, 2022 23:49
@tedd-an @BluezTestBot
workflow: Add workflow files
7179046 
This patch adds workflow files for ci:

[schedule_work.yml]
  - runs every 30 mins.
  - sync repo with upstream repo and rebase workflow branch to tip of
    master.
  - creates PR after reading patches from patchwork.kernel.org

[ci.yml]
  - Tests the following checks:
    - checkpatch
    - gitlint
    - make
    - make check

[code_scan.yml]
    - Static code checker: Coverity and Clang
    - Coverity: Submit the result to the coverity website
    - Clang Code Scan: Send email with result file to the internal team

To simplify the history, new change will amend to this patch without
creating new patch.
@mabhay125 @BluezTestBot
shared/bap: Fix handling for Company ID and Vendor Codec ID
cbe0716 
This adds fixes for handing for Company ID and Vendor Codec ID
while adding PAC record to database and responding to Attribute
Read Request for Sink/Source PAC Characteristics.
@mabhay125 @BluezTestBot
shared/bap: Add support to set stream metadata
c3f7df8 
This adds new API to set stream metadata.
@mabhay125 @BluezTestBot
profiles: Add Support for Metadata, CID and VID
a8f247c 
This adds support for Metadata, Company ID and Vendor Codec ID
@mabhay125 @BluezTestBot
media-api: Add CompanyID, VendorCodecID, Metadata
3e8b0e6 
This adds CompanyID, VendorCodecID, Metadata for RegisterEndpoint method
@mabhay125 @BluezTestBot
client/player: Add support for Metadata, CID, VID
6003d45 
This adds support for Metadata, Company ID and Vendor Codec ID.
This also adds handling of Vendor Specific Coding format.
Now it allows to enter zero codec capabilities.
It allows to enter zero metadata as well.
In order to register zero codec capabilities and metadata
0 shall be entered when prompted.
@BluezTestBot
Copy link
Owner Author

CheckPatch
Test ID: checkpatch
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Duration: 5.60 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 3.64 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 26.71 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Prep
Test ID: buildprep
Desc: Prepare environment for build
Duration: 0.68 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 8.32 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build - Make
Test ID: buildmake
Desc: Build the BlueZ source tree
Duration: 749.65 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 11.86 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 292.31 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 240.14 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build w/ext ELL - Configure
Test ID: build_extell
Desc: Configure BlueZ source with '--enable-external-ell' configuration
Duration: 8.38 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Build w/ext ELL - Make
Test ID: build_extell_make
Desc: Build BlueZ source with '--enable-external-ell' configuration
Duration: 85.77 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Incremental Build w/ patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 503.62 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

Scan Build
Test ID: scan_build
Desc: Run Scan Build with patches
Duration: 547.38 seconds
Result: WARNING

Output:

*****************************************************************************
The bugs reported by the scan-build may or may not be caused by your patches.
Please check the list and fix the bugs if they are caused by your patch.
*****************************************************************************
client/player.c:1770:25: warning: Dereference of null pointer
        iov_append(&cfg->caps, preset->data.iov_base, preset->data.iov_len);
                               ^~~~~~~~~~~~~~~~~~~~~
1 warning generated.
profiles/audio/media.c:1159:3: warning: Potential leak of memory pointed to by 'metadata'
                error("Could not allocate name for pac %s:%s",
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./src/log.h:62:2: note: expanded from macro 'error'
        btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
        ^~~~~~~~~
1 warning generated.

@tedd-an tedd-an force-pushed the workflow branch 2 times, most recently from 26640cd to ae73c50 Compare November 17, 2022 23:14
@BluezTestBot BluezTestBot deleted the 690159 branch November 17, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BluezTestBot @tedd-an @mabhay125