-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PW_SID:797481] [v2] shared/shell: Fix --init-script commandline option #1918
Conversation
This patch adds workflow files for ci: [sync.yml] - runs every 30 mins. - sync repo with upstream repo and rebase workflow branch to tip of master. - creates PR after reading patches from patchwork.kernel.org [ci.yml] - Tests the following checks: - checkpatch - gitlint - make - make check [code_scan.yml] - Static code checker: Coverity and Clang - Coverity: Submit the result to the coverity website - Clang Code Scan: Send email with result file to the internal team To simplify the history, new change will amend to this patch without creating new patch.
The newly added option -i/--init-script introduced a short option namespace collision with btmgmt's --index, both of which use '-i'. As a result, a provided --index is treated as a file name: $ sudo btmgmt --index 0 info Unable to open 0: No such file or directory (2) Fix this by using '-s' for --init-script. Fixes: bluez#639 Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
CheckPatch |
GitLint |
BuildEll |
BluezMake |
MakeCheck |
MakeDistcheck |
CheckValgrind |
CheckSmatch
|
bluezmakeextell |
IncrementalBuild |
ScanBuild |
53a9e32
to
0d338fe
Compare
The newly added option -i/--init-script introduced a short option
namespace collision with btmgmt's --index, both of which use '-i'.
As a result, a provided --index is treated as a file name:
$ sudo btmgmt --index 0 info
Unable to open 0: No such file or directory (2)
Fix this by using '-s' for --init-script.
Fixes: bluez#639
Signed-off-by: Juerg Haefliger juerg.haefliger@canonical.com
v2:
src/shared/shell.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)