Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:797481] [v2] shared/shell: Fix --init-script commandline option #1918

Closed
wants to merge 2 commits into from

Conversation

BluezTestBot
Copy link
Owner

The newly added option -i/--init-script introduced a short option
namespace collision with btmgmt's --index, both of which use '-i'.

As a result, a provided --index is treated as a file name:

$ sudo btmgmt --index 0 info
Unable to open 0: No such file or directory (2)

Fix this by using '-s' for --init-script.

Fixes: bluez#639
Signed-off-by: Juerg Haefliger juerg.haefliger@canonical.com


v2:

  • Replace reference to broken commit with reference to github issue.

src/shared/shell.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

tedd-an and others added 2 commits October 24, 2023 19:10
This patch adds workflow files for ci:

[sync.yml]
  - runs every 30 mins.
  - sync repo with upstream repo and rebase workflow branch to tip of
    master.
  - creates PR after reading patches from patchwork.kernel.org

[ci.yml]
  - Tests the following checks:
    - checkpatch
    - gitlint
    - make
    - make check

[code_scan.yml]
    - Static code checker: Coverity and Clang
    - Coverity: Submit the result to the coverity website
    - Clang Code Scan: Send email with result file to the internal team

To simplify the history, new change will amend to this patch without
creating new patch.
The newly added option -i/--init-script introduced a short option
namespace collision with btmgmt's --index, both of which use '-i'.

As a result, a provided --index is treated as a file name:

$ sudo btmgmt --index 0 info
Unable to open 0: No such file or directory (2)

Fix this by using '-s' for --init-script.

Fixes: bluez#639
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
@BluezTestBot
Copy link
Owner Author

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.42 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

GitLint
Desc: Run gitlint
Duration: 0.29 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

BuildEll
Desc: Build and Install ELL
Duration: 29.61 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

BluezMake
Desc: Build BlueZ
Duration: 951.63 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

MakeCheck
Desc: Run Bluez Make Check
Duration: 13.17 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

MakeDistcheck
Desc: Run Bluez Make Distcheck
Duration: 184.63 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

CheckValgrind
Desc: Run Bluez Make Check with Valgrind
Duration: 282.56 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

CheckSmatch
Desc: Run smatch tool with source
Duration: 379.14 seconds
Result: WARNING
Output:

src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):

@BluezTestBot
Copy link
Owner Author

bluezmakeextell
Desc: Build Bluez with External ELL
Duration: 121.60 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 785.02 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

ScanBuild
Desc: Run Scan Build
Duration: 1164.83 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 53a9e32 to 0d338fe Compare November 13, 2023 19:35
@BluezTestBot BluezTestBot deleted the 797481 branch November 13, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

btmgmt --index broken
3 participants