Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance #186

Merged
merged 8 commits into from
Apr 28, 2024
Merged

maintenance #186

merged 8 commits into from
Apr 28, 2024

Conversation

Bnaya
Copy link
Owner

@Bnaya Bnaya commented Apr 27, 2024

No description provided.

@Bnaya Bnaya marked this pull request as ready for review April 27, 2024 08:48
Copy link

codesandbox-ci bot commented Apr 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a1e4fd:

Sandbox Source
objectbuffer-demo-sort-array-on-webworker-no-data-copy Configuration
objectbuffer-comlink-demo-sort-array-on-webworker-no-data-copy Configuration

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benchmarkjs, node 20

Benchmark suite Current: fca5023 Previous: 446480a Ratio
create empty, size: 2e6 10949 ops/sec (±0.91%) 12785 ops/sec (±0.61%) 1.17
create with 2500 comments. size: 2e6 167 ops/sec (±0.41%) 168 ops/sec (±0.43%) 1.01
save 2500 comments into pre-created OB, size: 2e6 162 ops/sec (±1.35%) 162 ops/sec (±1.46%) 1
create with all mock data rows. size: 2e6 177 ops/sec (±1.78%) 182 ops/sec (±1.36%) 1.03
A-Z object keys 42291 ops/sec (±0.36%) 41242 ops/sec (±0.30%) 0.98
A-Z object prop Lookup in operator - non-existing 13705106 ops/sec (±0.53%) 14026775 ops/sec (±0.17%) 1.02
A-Z object prop Lookup in operator - existing 3064225 ops/sec (±0.33%) 3008255 ops/sec (±0.22%) 0.98
A-Z object prop access T 2896733 ops/sec (±0.23%) 2894162 ops/sec (±0.21%) 1.00
A-Z object prop access Z 2892421 ops/sec (±0.26%) 2893488 ops/sec (±0.25%) 1.00
OB_WITH_NA2Z_KEYS object keys 25839 ops/sec (±0.14%) 26210 ops/sec (±0.30%) 1.01
OB_WITH_NA2Z_KEYS object prop Lookup in operator - non-existing 1672984 ops/sec (±0.37%) 1733457 ops/sec (±0.31%) 1.04
OB_WITH_NA2Z_KEYS object prop Lookup in operator - existing 1617093 ops/sec (±0.27%) 1718990 ops/sec (±0.21%) 1.06
OB_WITH_NA2Z_KEYS object prop access 14ABCDEFGHIJKLMNOPQRSTUVWXYZ 1641008 ops/sec (±0.35%) 1674346 ops/sec (±0.25%) 1.02
OB_WITH_NA2Z_KEYS object prop access 3ABCDEFGHIJKLMNOPQRSTUVWXYZ 1678470 ops/sec (±0.34%) 1690715 ops/sec (±0.20%) 1.01
Array access. length: 1000 3947069 ops/sec (±0.25%) 4017035 ops/sec (±0.41%) 1.02
object memory free. K1000RowsMockData, pre-created OB, size: 2e6 17.83 ops/sec (±0.66%) 17.86 ops/sec (±0.66%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'benchmarkjs, node 20'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: fca5023 Previous: 446480a Ratio
create empty, size: 2e6 10949 ops/sec (±0.91%) 12785 ops/sec (±0.61%) 1.17

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Bnaya

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'benchmarkjs, node 18'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: 446480a Previous: f0964f7 Ratio
create empty, size: 2e6 10002 ops/sec (±3.53%) 11250 ops/sec (±4.04%) 1.12

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Bnaya

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'benchmarkjs, node 22'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: fca5023 Previous: 446480a Ratio
create empty, size: 2e6 10877 ops/sec (±1.08%) 12278 ops/sec (±1.37%) 1.13

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Bnaya

@Bnaya Bnaya merged commit 0d0fe1e into develop Apr 28, 2024
6 of 9 checks passed
@Bnaya Bnaya deleted the maintenance branch April 28, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant