Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maitenance #193

Merged
merged 3 commits into from
May 14, 2024
Merged

Maitenance #193

merged 3 commits into from
May 14, 2024

Conversation

Bnaya
Copy link
Owner

@Bnaya Bnaya commented May 14, 2024

No description provided.

Copy link

codesandbox-ci bot commented May 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b53a1a8:

Sandbox Source
objectbuffer-demo-sort-array-on-webworker-no-data-copy Configuration
objectbuffer-comlink-demo-sort-array-on-webworker-no-data-copy Configuration

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'benchmarkjs, node 22'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: 3d36966 Previous: fca5023 Ratio
create empty, size: 2e6 9688 ops/sec (±1.04%) 10877 ops/sec (±1.08%) 1.12

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Bnaya

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benchmarkjs, node 20

Benchmark suite Current: 92de37c Previous: 3d36966 Ratio
create empty, size: 2e6 8771 ops/sec (±0.95%) 11916 ops/sec (±0.78%) 1.36
create with 2500 comments. size: 2e6 163 ops/sec (±0.28%) 171 ops/sec (±0.24%) 1.05
save 2500 comments into pre-created OB, size: 2e6 156 ops/sec (±1.60%) 164 ops/sec (±1.48%) 1.05
create with all mock data rows. size: 2e6 176 ops/sec (±1.46%) 186 ops/sec (±0.65%) 1.06
A-Z object keys 41209 ops/sec (±0.50%) 41130 ops/sec (±0.16%) 1.00
A-Z object prop Lookup in operator - non-existing 13845867 ops/sec (±0.39%) 13989981 ops/sec (±0.26%) 1.01
A-Z object prop Lookup in operator - existing 2892058 ops/sec (±0.21%) 2882596 ops/sec (±0.79%) 1.00
A-Z object prop access T 2929289 ops/sec (±0.23%) 2885597 ops/sec (±0.41%) 0.99
A-Z object prop access Z 2926932 ops/sec (±0.26%) 2882176 ops/sec (±0.24%) 0.98
OB_WITH_NA2Z_KEYS object keys 25682 ops/sec (±0.18%) 25733 ops/sec (±0.24%) 1.00
OB_WITH_NA2Z_KEYS object prop Lookup in operator - non-existing 1633824 ops/sec (±0.38%) 1674174 ops/sec (±0.28%) 1.02
OB_WITH_NA2Z_KEYS object prop Lookup in operator - existing 1607771 ops/sec (±0.24%) 1661349 ops/sec (±0.22%) 1.03
OB_WITH_NA2Z_KEYS object prop access 14ABCDEFGHIJKLMNOPQRSTUVWXYZ 1618224 ops/sec (±0.28%) 1642152 ops/sec (±0.20%) 1.01
OB_WITH_NA2Z_KEYS object prop access 3ABCDEFGHIJKLMNOPQRSTUVWXYZ 1637523 ops/sec (±0.35%) 1654605 ops/sec (±0.23%) 1.01
Array access. length: 1000 3757807 ops/sec (±0.34%) 3789034 ops/sec (±0.34%) 1.01
object memory free. K1000RowsMockData, pre-created OB, size: 2e6 17.54 ops/sec (±0.92%) 17.78 ops/sec (±0.55%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@Bnaya Bnaya marked this pull request as ready for review May 14, 2024 04:20
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'benchmarkjs, node 20'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: 92de37c Previous: 3d36966 Ratio
create empty, size: 2e6 8771 ops/sec (±0.95%) 11916 ops/sec (±0.78%) 1.36

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Bnaya

@Bnaya Bnaya merged commit 72cd1d6 into develop May 14, 2024
6 of 11 checks passed
@Bnaya Bnaya deleted the maitenance branch May 14, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant