Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download model without loading #13

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

BobaZooba
Copy link
Owner

Description

User had insufficient RAM for the prepare step at xllm-demo project, it arises because, during this step, the model is downloaded and loaded into RAM. This approach is suboptimal, redundant, and may lead to similar instances that you've experienced. Simply downloading the model will suffice.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.

@BobaZooba BobaZooba self-assigned this Dec 6, 2023
@BobaZooba BobaZooba added the bug Something isn't working label Dec 6, 2023
@BobaZooba BobaZooba linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb2b5a6) 80.2% compared to head (4aa17cb) 80.2%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #13     +/-   ##
=======================================
- Coverage   80.2%   80.2%   -0.0%     
=======================================
  Files         38      38             
  Lines       1357    1356      -1     
=======================================
- Hits        1088    1087      -1     
  Misses       269     269             
Flag Coverage Δ
unit 80.2% <100.0%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BobaZooba BobaZooba merged commit 561d108 into main Dec 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading model into RAM at prepare step is redundant
1 participant