Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenizer trust remote code #2

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

BobaZooba
Copy link
Owner

@BobaZooba BobaZooba commented Nov 17, 2023

Description

When loading the tokenizer, there could have been issues, for example with the 01-ai/Yi-6B and 01-ai/Yi-34B models, as they have their own tokenizer. This is resolved by adding trust_remote_code to the tokenizer load.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1b50f0) 79.6% compared to head (99ad6ec) 79.6%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main      #2   +/-   ##
=====================================
  Coverage   79.6%   79.6%           
=====================================
  Files         38      38           
  Lines       1329    1329           
=====================================
  Hits        1058    1058           
  Misses       271     271           
Flag Coverage Δ
unit 79.6% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BobaZooba BobaZooba merged commit 94ca741 into main Nov 17, 2023
4 checks passed
@BobaZooba BobaZooba deleted the hotfix/tokenizer-remote-code branch November 17, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant