Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Handle verb forms with two first letters different from infinitive #210

Closed
lasconic opened this issue Nov 9, 2020 · 5 comments · Fixed by #211
Closed

[FR] Handle verb forms with two first letters different from infinitive #210

lasconic opened this issue Nov 9, 2020 · 5 comments · Fixed by #211

Comments

@lasconic
Copy link
Collaborator

lasconic commented Nov 9, 2020

A few verbs in french change dramatically when they are conjugued. Currently, if a verb form doesn't have the same two letters than the infinitive, they are not found.

List of verbs: https://gist.github.com/lasconic/d3fde4a6155528647703314153b2a8f7

@BoboTiG
Copy link
Owner

BoboTiG commented Nov 9, 2020

Is it expected to have "s’abstenir" instead of "abstenir" in your list?

@lasconic
Copy link
Collaborator Author

lasconic commented Nov 9, 2020

No it's not but that's a bug for wiktionary. Same for variant :'verbes' : word : 'somment'. I tried to fix this one.

@BoboTiG
Copy link
Owner

BoboTiG commented Nov 10, 2020

Surprisingly, there is no change in the words count before and after the patch. I thought there would be more words taken into account 🤔
See yesterday and today.

(And when checking those logs, I saw new errors: upcoming tickets :)

@lasconic
Copy link
Collaborator Author

This is weird. I just tested on my device and the verb forms are found when I search in the dictionary: meaning I get an autocomplete but no definition is displayed. I do see a definition in the HTML file once gunzipped though. I will try to investigate.

@lasconic lasconic reopened this Nov 10, 2020
@lasconic
Copy link
Collaborator Author

lasconic commented Nov 10, 2020

Ok. I didn't test on my device with the right dictionary... It does work.

Surprisingly, there is no change in the words count before and after the patch. I thought there would be more words taken into account 🤔

If you compare the word count in data.json, it's normal. The PR only changed the convert step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants