Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Handle "cit_réf" / "cit réf" template #323

Closed
lasconic opened this issue Nov 22, 2020 · 4 comments · Fixed by #333
Closed

[FR] Handle "cit_réf" / "cit réf" template #323

lasconic opened this issue Nov 22, 2020 · 4 comments · Fixed by #333
Assignees

Comments

@lasconic
Copy link
Collaborator

Wikicode:

{{cit_réf|Rabelais|Quart livre, c 56, 1552}}

Output:


Expected:

<i>Rabelais</i>, Quart livre, c 56, 1552

Model link, if any: https://fr.wiktionary.org/wiki/Mod%C3%A8le:cit_r%C3%A9f

@BoboTiG
Copy link
Owner

BoboTiG commented Nov 22, 2020

Should we handle or ignore it? It seems like other citation templates we are actually ignoring 🤔

@lasconic
Copy link
Collaborator Author

it's only one article but here we have empty parenthesis () in the text if we ignore it. It's your call ;)

@BoboTiG
Copy link
Owner

BoboTiG commented Nov 23, 2020

Empty parentheses is not what we want. Let's handle it then :)

@BoboTiG
Copy link
Owner

BoboTiG commented Nov 23, 2020

And maybe "cité_ref" should be fixed on Wiktionary directly. (And here my last patch that removed printing all templates is not helping... :)

@lasconic lasconic self-assigned this Nov 23, 2020
lasconic added a commit to lasconic/ebook-reader-dict that referenced this issue Nov 23, 2020
lasconic added a commit to lasconic/ebook-reader-dict that referenced this issue Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants